Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2979703002:
Outputing json test results to output.json (Closed)
|
Created:
3 years, 5 months ago by ashleymarie1 Modified:
3 years, 5 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionOutputing json test results to output.json
BUG=chromium:717394
Review-Url: https://codereview.chromium.org/2979703002
Cr-Commit-Position: refs/heads/master@{#485984}
Committed: https://chromium.googlesource.com/chromium/src/+/1b0335dbe961d4ca985cb845c5bf7af37b24e7b2
Patch Set 1 #Patch Set 2 : Outputing json test results to output.json #
Total comments: 3
Patch Set 3 : simplifying logic in run_telemetry_benchmark_as_googletest #Messages
Total messages: 25 (17 generated)
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ashleymarie@chromium.org changed reviewers: + nednguyen@google.com, perezju@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm w/nit and question https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... File testing/scripts/run_telemetry_benchmark_as_googletest.py (right): https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... testing/scripts/run_telemetry_benchmark_as_googletest.py:131: json_results = json_test_results nit: maybe this could just be: if not json_test_results_present: json_test_results = {'valid': ... } json.dump(json_test_results, ...) https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... testing/scripts/run_telemetry_benchmark_as_googletest.py:132: json.dump(json_results, args.isolated_script_test_output) Higher level question. Do clients (e.g. build bot) know how to deal with both the simple valid-failures dict and the full test-results.json?
On 2017/07/12 08:07:59, perezju wrote: > lgtm w/nit and question > > https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... > File testing/scripts/run_telemetry_benchmark_as_googletest.py (right): > > https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... > testing/scripts/run_telemetry_benchmark_as_googletest.py:131: json_results = > json_test_results > nit: maybe this could just be: > > if not json_test_results_present: > json_test_results = {'valid': ... } > json.dump(json_test_results, ...) > > https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... > testing/scripts/run_telemetry_benchmark_as_googletest.py:132: > json.dump(json_results, args.isolated_script_test_output) > Higher level question. Do clients (e.g. build bot) know how to deal with both > the simple valid-failures dict and the full test-results.json? This is only used by swarming, which knows how to deal with both: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_...
On 2017/07/12 10:19:14, nednguyen wrote: > On 2017/07/12 08:07:59, perezju wrote: > > lgtm w/nit and question > > > > > https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... > > File testing/scripts/run_telemetry_benchmark_as_googletest.py (right): > > > > > https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... > > testing/scripts/run_telemetry_benchmark_as_googletest.py:131: json_results = > > json_test_results > > nit: maybe this could just be: > > > > if not json_test_results_present: > > json_test_results = {'valid': ... } > > json.dump(json_test_results, ...) > > > > > https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... > > testing/scripts/run_telemetry_benchmark_as_googletest.py:132: > > json.dump(json_results, args.isolated_script_test_output) > > Higher level question. Do clients (e.g. build bot) know how to deal with both > > the simple valid-failures dict and the full test-results.json? > > This is only used by swarming, which knows how to deal with both: > https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_... Awesome. Thanks!
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
And yep what Ned said about swarming being able to handle it :) https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... File testing/scripts/run_telemetry_benchmark_as_googletest.py (right): https://codereview.chromium.org/2979703002/diff/20001/testing/scripts/run_tel... testing/scripts/run_telemetry_benchmark_as_googletest.py:131: json_results = json_test_results On 2017/07/12 08:07:58, perezju wrote: > nit: maybe this could just be: > > if not json_test_results_present: > json_test_results = {'valid': ... } > json.dump(json_test_results, ...) Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ashleymarie@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, perezju@chromium.org Link to the patchset: https://codereview.chromium.org/2979703002/#ps40001 (title: "simplifying logic in run_telemetry_benchmark_as_googletest")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499875692499170,
"parent_rev": "528b5d650eba7b4ded686622888a20d4e0a27b1b", "commit_rev":
"1b0335dbe961d4ca985cb845c5bf7af37b24e7b2"}
Message was sent while issue was closed.
Description was changed from ========== Outputing json test results to output.json BUG=chromium:717394 ========== to ========== Outputing json test results to output.json BUG=chromium:717394 Review-Url: https://codereview.chromium.org/2979703002 Cr-Commit-Position: refs/heads/master@{#485984} Committed: https://chromium.googlesource.com/chromium/src/+/1b0335dbe961d4ca985cb845c5bf... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1b0335dbe961d4ca985cb845c5bf... |
