Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 297963005: Make reconnection in response to video channel inactivity less aggressive. (Closed)

Created:
6 years, 7 months ago by Sergey Ulanov
Modified:
6 years, 7 months ago
Reviewers:
Jamie, Wez, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Make reconnection in response to video channel inactivity less aggressive. Previously immediate reconnection was triggered by the video channel becoming inactive. That can cause spurious reconnects on flaky networks. Now the webapp will always wait for 10 seconds before trying to reconnect. BUG=375568 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272695

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M remoting/webapp/smart_reconnector.js View 1 2 chunks +3 lines, -13 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
Sergey Ulanov
6 years, 7 months ago (2014-05-23 19:48:56 UTC) #1
Jamie
lgtm
6 years, 7 months ago (2014-05-23 20:21:16 UTC) #2
Wez
lgtm https://codereview.chromium.org/297963005/diff/20001/remoting/webapp/smart_reconnector.js File remoting/webapp/smart_reconnector.js (left): https://codereview.chromium.org/297963005/diff/20001/remoting/webapp/smart_reconnector.js#oldcode110 remoting/webapp/smart_reconnector.js:110: if (navigator.onLine) { Would it be better to ...
6 years, 7 months ago (2014-05-23 20:26:39 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/297963005/diff/20001/remoting/webapp/smart_reconnector.js File remoting/webapp/smart_reconnector.js (left): https://codereview.chromium.org/297963005/diff/20001/remoting/webapp/smart_reconnector.js#oldcode110 remoting/webapp/smart_reconnector.js:110: if (navigator.onLine) { On 2014/05/23 20:26:40, Wez wrote: > ...
6 years, 7 months ago (2014-05-23 20:38:35 UTC) #4
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-23 20:38:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/297963005/20001
6 years, 7 months ago (2014-05-23 20:39:56 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 03:13:14 UTC) #7
Message was sent while issue was closed.
Change committed as 272695

Powered by Google App Engine
This is Rietveld 408576698