Make reconnection in response to video channel inactivity less aggressive.

remoting/webapp/smart_reconnector.js

Index: remoting/webapp/smart_reconnector.js
diff --git a/remoting/webapp/smart_reconnector.js b/remoting/webapp/smart_reconnector.js
index 55186b4205e68abd76e6d0cd58eae5af10e639ec..7cc50bfb0257fb4f0a30b5514851a994a00de259 100644
--- a/remoting/webapp/smart_reconnector.js
+++ b/remoting/webapp/smart_reconnector.js
@@ -62,8 +62,7 @@ remoting.SmartReconnector = function(connector, clientSession) {
 // to connect.
 remoting.SmartReconnector.kReconnectDelay = 2000;
 
-// If no frames are received from the server for more than |kConnectionTimeout|,
-// disconnect the session.
+// If the video channel is inactive for 10 seconds reconnect the session.
 remoting.SmartReconnector.kConnectionTimeout = 10000;
 
 remoting.SmartReconnector.prototype = {
@@ -97,22 +96,13 @@ remoting.SmartReconnector.prototype = {
   },
 
   /**
-   * @param {boolean} active  This function is called if no frames are received
-   *    on the client for more than 1 second.
+   * @param {boolean} active  True if the video channel is active.
    */
   videoChannelStateChanged_: function (active) {
     this.cancelPending_();
     if (!active) {
-      // If the channel becomes inactive due to a lack of network connection,
-      // wait for it to go online.  The plugin will try to reconnect the video
-      // channel once it is online.  If the video channels doesn't finish
-      // reconnecting within the timeout, tear down the session and reconnect.
-      if (navigator.onLine) {

[Wez, 2014/05/23 20:26:40]

Would it be better to just have a shorter timeout for the am-online case, before
reconnecting?  Or is navigator.onLine just too unreliable for our purposes?

[Sergey Ulanov, 2014/05/23 20:38:36]

navigator.onLine=true just tells us that the machine might be online. It's still
possible that network is broken. So I don't think we should treat that case
differently.

-        this.reconnect_();
-      } else {
-        window.addEventListener(
+      window.addEventListener(
           'online', this.bound_.startReconnectTimeout, false);
-      }
     }
   },