Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2979593002: config_service: set memcache timeout (Closed)

Created:
3 years, 5 months ago by nodir
Modified:
3 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: set memcache timeout storage.get_self_config_async memcaches results indefintely, thus app may not see changes. Set an expiration of 1min R=vadimsh@chromium.org BUG=737781 Review-Url: https://codereview.chromium.org/2979593002 Committed: https://github.com/luci/luci-py/commit/131a21b1c390df4dd2139b4ded1bdfce9c605648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M appengine/config_service/storage.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
nodir
PTAL
3 years, 5 months ago (2017-07-10 21:55:29 UTC) #1
Vadim Sh.
lgtm
3 years, 5 months ago (2017-07-10 21:57:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2979593002/1
3 years, 5 months ago (2017-07-10 21:57:40 UTC) #4
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 22:00:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/131a21b1c390df4dd2139b4ded1bdfce9c605648

Powered by Google App Engine
This is Rietveld 408576698