Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2979563002: Use same DesktopCaptureOptions in DesktopCaptureBase and DesktopCaptureDevice (Closed)

Created:
3 years, 5 months ago by Hzj_jie
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Use same DesktopCaptureOptions in DesktopCaptureBase and DesktopCaptureDevice DesktopCaptureOptions impacts which underlying DesktopCapturer implementation is used. But there is no guarantee that different DesktopCapturer implementations would eventually return the same SourceList, or a Source in the SourceList represents the same output content on the system. So DesktopCaptureBase and DesktopCaptureDevice should use same DesktopCaptureOptions. BUG=732224 Review-Url: https://codereview.chromium.org/2961193002 Cr-Original-Commit-Position: refs/heads/master@{#485097} (cherry picked from commit 56efe642b5d1fc400ac7f34451d9a540f9d30fbb) Review-Url: https://codereview.chromium.org/2979563002 . Cr-Commit-Position: refs/branch-heads/3112@{#560} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/bf819e8a3d126f2a68bc631d89bb48a308ef6d50

Patch Set 1 #

Patch Set 2 : Merge remote-tracking branch 'refs/remotes/branch-heads/3112' into drover_3112 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -24 lines) Patch
M chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 4 chunks +2 lines, -20 lines 0 comments Download
M content/public/browser/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M content/public/browser/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A content/public/browser/desktop_capture.h View 1 chunk +18 lines, -0 lines 0 comments Download
A content/public/browser/desktop_capture.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
Hzj_jie
3 years, 5 months ago (2017-07-10 18:02:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bf819e8a3d126f2a68bc631d89bb48a308ef6d50.

Powered by Google App Engine
This is Rietveld 408576698