Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2979433003: Help text for gae.py upload about module yaml naming. (Closed)

Created:
3 years, 5 months ago by RobertoCN
Modified:
3 years, 5 months ago
Reviewers:
Vadim Sh., agable
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Help text for gae.py upload about module yaml naming. Since gae.py detects the non-default modules of an app by this convention, it should be shown to the user in the help text. R=agable@chromium.org,vadimsh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2979433003 Committed: https://github.com/luci/luci-py/commit/5ad681468decbf4b9b326217d105ba6b80a164f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M appengine/components/tools/gae.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
RobertoCN
PTAL, this time in the right review system
3 years, 5 months ago (2017-07-07 21:28:00 UTC) #1
Vadim Sh.
lgtm
3 years, 5 months ago (2017-07-07 21:44:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2979433003/1
3 years, 5 months ago (2017-07-07 21:53:02 UTC) #4
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 21:56:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/5ad681468decbf4b9b326217d105ba6b80a164f6

Powered by Google App Engine
This is Rietveld 408576698