milo/buildsource/buildbucket/pubsub.go - Issue 2979283002: Add manifest links and hack to index on revision.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/buildsource/buildbucket/pubsub.go

Issue 2979283002: Add manifest links and hack to index on revision. (Closed)

Patch Set: actually upload Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/buildsource/buildbucket/pubsub.go

diff --git a/milo/buildsource/buildbucket/pubsub.go b/milo/buildsource/buildbucket/pubsub.go

index 077be7dbcaf9d5a1df175d138373e1781d401cd2..6b8c41a7fc2c73f4d845b516f6a45b80eed768bb 100644

--- a/milo/buildsource/buildbucket/pubsub.go

+++ b/milo/buildsource/buildbucket/pubsub.go

@@ -164,7 +164,9 @@ func saveBuildSummary(

}

if entry.respBuild != nil {

// Add info from the respBuild into the build summary if we have the data.

- entry.respBuild.SummarizeTo(&bs)

+ if err := entry.respBuild.SummarizeTo(c, &bs); err != nil {

+ return err

+ }

}

logging.Debugf(c, "Created build summary: %#v", bs)

// Make datastore flakes transient errors

« no previous file with comments | « milo/buildsource/buildbot/pubsub.go ('k') | milo/common/config.go » ('j') | no next file with comments »