[Extensions] Don't allow content scripts on the New Tab Page

extensions/browser/script_executor.cc

Index: extensions/browser/script_executor.cc
diff --git a/extensions/browser/script_executor.cc b/extensions/browser/script_executor.cc
index db2c02da3031784a258f5e4abb7ac972cee8d177..1f6c10eab3815b520f8b8d2e4b2d841707436dcd 100644
--- a/extensions/browser/script_executor.cc
+++ b/extensions/browser/script_executor.cc
@@ -135,6 +135,8 @@ class Handler : public content::WebContentsObserver {
     DCHECK(erased);
     bool is_root_frame = root_rfh_ == render_frame_host;
 
+    LOG(WARNING) << "Done: " << error << ", " << on_url;

[karandeepb, 2017/07/18 21:06:26]

Remove logging in this file as well.

[Devlin, 2017/07/18 21:12:49]

D'oh.  Don't know how I missed so many on this CL.  Thanks for your diligence,
and sorry for needing repeated comments!

+
     // Set the result, if there is one.
     const base::Value* script_value = nullptr;
     if (result_list.Get(0u, &script_value)) {
@@ -158,9 +160,11 @@ class Handler : public content::WebContentsObserver {
 
   void Finish() {
     if (root_frame_url_.is_empty()) {
+      LOG(WARNING) << "Failed: " << root_frame_error_;
       // We never finished the root frame injection.
       root_frame_error_ =
           root_is_main_frame_ ? kRendererDestroyed : kFrameRemoved;
+      LOG(WARNING) << "New: " << root_frame_error_;
       results_.Clear();
     }