[Extensions] Don't allow content scripts on the New Tab Page

extensions/browser/script_executor.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/script_executor.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 117 matching lines @@
                              int request_id,
                              const std::string& error,
                              const GURL& on_url,
                              const base::ListValue& result_list) {
     DCHECK_EQ(request_id_, request_id);
     DCHECK(!pending_render_frames_.empty());
     bool erased = pending_render_frames_.erase(render_frame_host) == 1;
     DCHECK(erased);
     bool is_root_frame = root_rfh_ == render_frame_host;
 
+    LOG(WARNING) << "Done: " << error << ", " << on_url;

[karandeepb, 2017/07/18 21:06:26]

Remove logging in this file as well.

[Devlin, 2017/07/18 21:12:49]

D'oh.  Don't know how I missed so many on this CL.  Thanks for your diligence,
and sorry for needing repeated comments!

+
     // Set the result, if there is one.
     const base::Value* script_value = nullptr;
     if (result_list.Get(0u, &script_value)) {
       // If this is the main result, we put it at index 0. Otherwise, we just
       // append it at the end.
       if (is_root_frame && !results_.empty())
         CHECK(results_.Insert(0u, script_value->CreateDeepCopy()));
       else
         results_.Append(script_value->CreateDeepCopy());
     }
 
     if (is_root_frame) {  // Only use the root frame's error and url.
       root_frame_error_ = error;
       root_frame_url_ = on_url;
     }
 
     // Wait until the final request finishes before reporting back.
     if (pending_render_frames_.empty())
       Finish();
   }
 
   void Finish() {
     if (root_frame_url_.is_empty()) {
+      LOG(WARNING) << "Failed: " << root_frame_error_;
       // We never finished the root frame injection.
       root_frame_error_ =
           root_is_main_frame_ ? kRendererDestroyed : kFrameRemoved;
+      LOG(WARNING) << "New: " << root_frame_error_;
       results_.Clear();
     }
 
     if (script_observers_.get() && root_frame_error_.empty() &&
         host_id_.type() == HostID::EXTENSIONS) {
       ScriptExecutionObserver::ExecutingScriptsMap id_map;
       id_map[host_id_.id()] = std::set<std::string>();
       for (auto& observer : *script_observers_)
         observer.OnScriptsExecuted(web_contents(), id_map, root_frame_url_);
     }
@@ skipping 94 matching lines @@
   params.file_url = file_url;
   params.wants_result = (result_type == JSON_SERIALIZED_RESULT);
   params.user_gesture = user_gesture;
 
   // Handler handles IPCs and deletes itself on completion.
   new Handler(script_observers_, web_contents_, params, frame_scope, frame_id,
               callback);
 }
 
 }  // namespace extensions