Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2978933002: Add alert timestamps, bisect start, and convert bug timestamps to ISO format. (Closed)

Created:
3 years, 5 months ago by sullivan
Modified:
3 years, 5 months ago
Reviewers:
shatch
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix started_timestamp name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M dashboard/dashboard/alerts.py View 1 chunk +1 line, -0 lines 0 comments Download
M dashboard/dashboard/api/bugs.py View 1 2 chunks +3 lines, -8 lines 0 comments Download
M dashboard/dashboard/api/bugs_test.py View 1 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sullivan
Juan pointed out this would be better if all the timestamps were in UTC, and ...
3 years, 5 months ago (2017-07-13 15:32:05 UTC) #2
shatch
lgtm https://codereview.chromium.org/2978933002/diff/1/dashboard/dashboard/api/bugs.py File dashboard/dashboard/api/bugs.py (right): https://codereview.chromium.org/2978933002/diff/1/dashboard/dashboard/api/bugs.py#newcode53 dashboard/dashboard/api/bugs.py:53: 'started_datetime': b.last_ran_timestamp.isoformat(), nit: Every reference including in description ...
3 years, 5 months ago (2017-07-13 15:35:49 UTC) #3
sullivan
https://codereview.chromium.org/2978933002/diff/1/dashboard/dashboard/api/bugs.py File dashboard/dashboard/api/bugs.py (right): https://codereview.chromium.org/2978933002/diff/1/dashboard/dashboard/api/bugs.py#newcode53 dashboard/dashboard/api/bugs.py:53: 'started_datetime': b.last_ran_timestamp.isoformat(), On 2017/07/13 15:35:49, shatch wrote: > nit: ...
3 years, 5 months ago (2017-07-13 16:20:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978933002/20001
3 years, 5 months ago (2017-07-13 16:20:39 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 16:48:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698