[Extensions][Task Scheduler] Migrate ExecuteCodeFunction

extensions/browser/api/execute_code_function.h

Index: extensions/browser/api/execute_code_function.h
diff --git a/extensions/browser/api/execute_code_function.h b/extensions/browser/api/execute_code_function.h
index 13df3dd544b41588db6843e5ca9dffbca7f72eb8..5401799bd84cb8e739343b1a7b1f1e3292e26cb6 100644
--- a/extensions/browser/api/execute_code_function.h
+++ b/extensions/browser/api/execute_code_function.h
@@ -84,7 +84,7 @@ class ExecuteCodeFunction : public AsyncExtensionFunction {
   // localizes |data|.
   // Localization depends on whether |might_require_localization| was specified.
   // Only CSS file content needs to be localized.
-  void GetFileURLAndMaybeLocalizeOnFileThread(
+  void GetFileURLAndMaybeLocalizeOnBackgroundThread(

[karandeepb, 2017/07/13 01:47:48]

Why "Background"? 

Maybe GetFileURLAndMaybeLocalizeOnFileSequence?

[Devlin, 2017/07/13 18:35:09]

"Background" is just the idea of a background thread (i.e., not UI). 
FileSequence isn't quite right, I think, because it implies a file thread (which
is what we're moving away from), and these aren't run on a specific sequence. 
I've also seen "InBackground", or we can just remove the suffix entirely...
wdyt?

[karandeepb, 2017/07/13 20:18:48]

Background seems to tell me that this is run on a sequence with background
priority which may not be true. However if this is also used similarly at other
places in the codebase, then this sg.

[Devlin, 2017/07/14 00:52:03]

Done.

       const std::string& extension_id,
       const base::FilePath& extension_path,
       const std::string& extension_default_locale,
@@ -93,9 +93,10 @@ class ExecuteCodeFunction : public AsyncExtensionFunction {
 
   // Retrieves the file url for the given |extension_path| and optionally
   // localizes |data|.
-  // Similar to GetFileURLAndMaybeLocalizeOnFileThread, but only applies to
-  // component extension resource.
-  void GetFileURLAndLocalizeComponentResourceOnFileThread(
+  // Similar to GetFileURLAndMaybeLocalizeOnBackgroundThread, but only applies
+  // to component extension resource.
+  std::unique_ptr<std::string>
+  GetFileURLAndLocalizeComponentResourceOnBackgroundThread(
       std::unique_ptr<std::string> data,
       const std::string& extension_id,
       const base::FilePath& extension_path,