[Extensions][Task Scheduler] Migrate ExecuteCodeFunction

extensions/browser/api/execute_code_function.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_EXECUTE_CODE_FUNCTION_H_
 #define EXTENSIONS_BROWSER_API_EXECUTE_CODE_FUNCTION_H_
 
 #include "base/macros.h"
 #include "base/optional.h"
 #include "extensions/browser/extension_function.h"
@@ skipping 66 matching lines @@
   std::unique_ptr<api::extension_types::InjectDetails> details_;
   base::Optional<InitResult> init_result_;
   // Set iff |init_result_| == FAILURE, holds the error string.
   base::Optional<std::string> init_error_;
 
  private:
   // Retrieves the file url for the given |extension_path| and optionally
   // localizes |data|.
   // Localization depends on whether |might_require_localization| was specified.
   // Only CSS file content needs to be localized.
-  void GetFileURLAndMaybeLocalizeOnFileThread(
+  void GetFileURLAndMaybeLocalizeOnBackgroundThread(

[karandeepb, 2017/07/13 01:47:48]

Why "Background"? 

Maybe GetFileURLAndMaybeLocalizeOnFileSequence?

[Devlin, 2017/07/13 18:35:09]

"Background" is just the idea of a background thread (i.e., not UI). 
FileSequence isn't quite right, I think, because it implies a file thread (which
is what we're moving away from), and these aren't run on a specific sequence. 
I've also seen "InBackground", or we can just remove the suffix entirely...
wdyt?

[karandeepb, 2017/07/13 20:18:48]

Background seems to tell me that this is run on a sequence with background
priority which may not be true. However if this is also used similarly at other
places in the codebase, then this sg.

[Devlin, 2017/07/14 00:52:03]

Done.

       const std::string& extension_id,
       const base::FilePath& extension_path,
       const std::string& extension_default_locale,
       bool might_require_localization,
       std::string* data);
 
   // Retrieves the file url for the given |extension_path| and optionally
   // localizes |data|.
-  // Similar to GetFileURLAndMaybeLocalizeOnFileThread, but only applies to
-  // component extension resource.
-  void GetFileURLAndLocalizeComponentResourceOnFileThread(
+  // Similar to GetFileURLAndMaybeLocalizeOnBackgroundThread, but only applies
+  // to component extension resource.
+  std::unique_ptr<std::string>
+  GetFileURLAndLocalizeComponentResourceOnBackgroundThread(
       std::unique_ptr<std::string> data,
       const std::string& extension_id,
       const base::FilePath& extension_path,
       const std::string& extension_default_locale,
       bool might_require_localization);
 
   // Run in UI thread.  Code string contains the code to be executed. Returns
   // true on success. If true is returned, this does an AddRef.
   bool Execute(const std::string& code_string);
 
   // Contains extension resource built from path of file which is
   // specified in JSON arguments.
   ExtensionResource resource_;
 
   // The URL of the file being injected into the page.
   GURL file_url_;
 
   // The ID of the injection host.
   HostID host_id_;
 
   DISALLOW_COPY_AND_ASSIGN(ExecuteCodeFunction);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_EXECUTE_CODE_FUNCTION_H_