Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2978713002: DevTools: migrate PropertiesWidget to shadow (Closed)

Created:
3 years, 5 months ago by luoe
Modified:
3 years, 5 months ago
Reviewers:
caseq, chenwilliam
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate PropertiesWidget to shadow BUG=726972 Review-Url: https://codereview.chromium.org/2978713002 Cr-Commit-Position: refs/heads/master@{#488482} Committed: https://chromium.googlesource.com/chromium/src/+/23eca3d61bd69eeaec6ca6554f7fb99a7c566d14

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/elements/propertiesWidget.css View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
luoe
caseq@, could you please take a look?
3 years, 5 months ago (2017-07-11 22:29:15 UTC) #2
luoe
gentle ping @caseq
3 years, 5 months ago (2017-07-19 01:21:17 UTC) #4
caseq
Apologies, somehow missed this. lgtm.
3 years, 5 months ago (2017-07-20 00:06:52 UTC) #5
luoe
On 2017/07/20 00:06:52, caseq wrote: > Apologies, somehow missed this. lgtm. No worries, thanks for ...
3 years, 5 months ago (2017-07-20 00:07:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978713002/1
3 years, 5 months ago (2017-07-20 00:07:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/467547) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 5 months ago (2017-07-20 00:12:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978713002/20001
3 years, 5 months ago (2017-07-20 20:26:12 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-20 23:38:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/23eca3d61bd69eeaec6ca6554f7f...

Powered by Google App Engine
This is Rietveld 408576698