Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2978693002: Remove all calls to domAutomationController.setAutomationId. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews, tfarina, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=nasko@chromium.org Review-Url: https://codereview.chromium.org/2978693002 Cr-Commit-Position: refs/heads/master@{#485958} Committed: https://chromium.googlesource.com/chromium/src/+/6bd45405064ad250f27663f089a00af8769244bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Łukasz Anforowicz
paulmeyer@, can you PTAL?
3 years, 5 months ago (2017-07-11 23:48:59 UTC) #4
paulmeyer
On 2017/07/11 23:48:59, Łukasz A. wrote: > paulmeyer@, can you PTAL? LGTM
3 years, 5 months ago (2017-07-12 11:38:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978693002/1
3 years, 5 months ago (2017-07-12 15:20:40 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 15:25:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6bd45405064ad250f27663f089a0...

Powered by Google App Engine
This is Rietveld 408576698