Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2978673002: Update print preview test to not use CallJavascriptFunctionUnsafe (Closed)

Created:
3 years, 5 months ago by rbpotter
Modified:
3 years, 5 months ago
Reviewers:
Lei Zhang, dpapad
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update print preview test to not use CallJavascriptFunctionUnsafe Manual test uses CallJavascriptFunctionUnsafe. Print preview has been updated to use WebUI listener for this function instead, so update the test to match. BUG=717296 Review-Url: https://codereview.chromium.org/2978673002 Cr-Commit-Position: refs/heads/master@{#485767} Committed: https://chromium.googlesource.com/chromium/src/+/82a8567da54863660f1743b70a8bfb9d79658905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M chrome/browser/printing/print_preview_pdf_generated_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
rbpotter
3 years, 5 months ago (2017-07-11 20:30:32 UTC) #5
dpapad
Is this test disabled because it was failing on some bots, or is it a ...
3 years, 5 months ago (2017-07-11 21:09:57 UTC) #6
rbpotter
On 2017/07/11 21:09:57, dpapad wrote: > Is this test disabled because it was failing on ...
3 years, 5 months ago (2017-07-11 21:38:01 UTC) #8
Lei Zhang
lgtm Can we mention "print preview test" in first line of the CL description? The ...
3 years, 5 months ago (2017-07-11 21:51:11 UTC) #9
dpapad
lgtm
3 years, 5 months ago (2017-07-11 23:32:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978673002/1
3 years, 5 months ago (2017-07-12 00:09:30 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 01:27:14 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/82a8567da54863660f1743b70a8b...

Powered by Google App Engine
This is Rietveld 408576698