Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297863004: Merge 174141 "HTML Imports: Take care of cycles according to the..." (Closed)

Created:
6 years, 7 months ago by Hajime Morrita
Modified:
6 years, 7 months ago
Reviewers:
Hajime Morrita
CC:
blink-reviews, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Visibility:
Public.

Description

Merge 174141 "HTML Imports: Take care of cycles according to the..." > HTML Imports: Take care of cycles according to the spec. > > This fixes for regression that blocks import cycle indefinitely. > The change has two points: > > * Let isBlockingFollowers() see HTMLImportChild::isFirst(). The > isFirst() corresponds to the notion of "marked as branch" in the spec. > * Make CustomElementMicrosaskImportStep aware of tree shuffling done by > HTMLImportChild::normalize(). > > TEST=import-cycle-*.html > R=dglazkov@chromium.org, dominicc@chromium.org > BUG=373461 > > Review URL: https://codereview.chromium.org/289993004 TBR=morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, --29 lines) Patch
A + LayoutTests/fast/html/imports/import-cycle-grandparent.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-grandparent-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-child-1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-child-1-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-child-2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-child-2-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-child-3.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-child-3-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-grandparent.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-grandparent-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-two-parents-1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-two-parents-1-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-two-parents-2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-two-parents-2-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-two-parents-3.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-two-parents-3-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-grandparent-a.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-grandparent-b.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-grandparent-c.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-a.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-b.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-1-a.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-1-b.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-1-c.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-1-d.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-2-a.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-2-b.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-3-a.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-3-b.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-grandparent-a.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-grandparent-b.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-grandparent-c.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-two-parents-1-a.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-two-parents-1-b.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-two-parents-1-c.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-two-parents-2-a.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-two-parents-2-b.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-two-parents-2-c.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-two-parents-3-a.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-two-parents-3-b.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-two-parents-3-c.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskImportStep.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskImportStep.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportChild.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportChild.cpp View 3 chunks +28 lines, -4 lines 0 comments Download
M Source/core/html/imports/HTMLImportLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportLoader.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/html/imports/HTMLImportStateResolver.cpp View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hajime Morrita
6 years, 7 months ago (2014-05-22 21:03:03 UTC) #1
Hajime Morrita
6 years, 7 months ago (2014-05-22 21:03:31 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r174597.

Powered by Google App Engine
This is Rietveld 408576698