Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 289993004: HTML Imports: Take care of cycles according to the spec. (Closed)

Created:
6 years, 7 months ago by Hajime Morrita
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Visibility:
Public.

Description

HTML Imports: Take care of cycles according to the spec. This fixes for regression that blocks import cycle indefinitely. The change has two points: * Let isBlockingFollowers() see HTMLImportChild::isFirst(). The isFirst() corresponds to the notion of "marked as branch" in the spec. * Make CustomElementMicrosaskImportStep aware of tree shuffling done by HTMLImportChild::normalize(). TEST=import-cycle-*.html R=dglazkov@chromium.org, dominicc@chromium.org BUG=373461 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -26 lines) Patch
A LayoutTests/fast/html/imports/import-cycle-grandparent.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-grandparent-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/html/imports/import-cycle-parent.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-cycle-parent-child-1.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-child-1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/html/imports/import-cycle-parent-child-2.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-child-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/html/imports/import-cycle-parent-child-3.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-child-3-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/html/imports/import-cycle-parent-grandparent.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-parent-grandparent-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/html/imports/import-cycle-two-parents-1.html View 1 chunk +21 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-two-parents-1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/html/imports/import-cycle-two-parents-2.html View 1 chunk +21 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-two-parents-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/html/imports/import-cycle-two-parents-3.html View 1 chunk +21 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-cycle-two-parents-3-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-grandparent-a.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-grandparent-b.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-grandparent-c.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-parent-a.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-parent-b.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-parent-child-1-a.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-parent-child-1-b.html View 1 chunk +6 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-1-c.html View 1 chunk +0 lines, -1 line 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-1-d.html View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-parent-child-2-a.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-parent-child-2-b.html View 1 chunk +6 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/resources/cycle-parent-child-3-a.html View 1 chunk +4 lines, -1 line 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-parent-child-3-b.html View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-parent-grandparent-a.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-parent-grandparent-b.html View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-parent-grandparent-c.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-two-parents-1-a.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-two-parents-1-b.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-two-parents-1-c.html View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-two-parents-2-a.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-two-parents-2-b.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-two-parents-2-c.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-two-parents-3-a.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-two-parents-3-b.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/cycle-two-parents-3-c.html View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskImportStep.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskImportStep.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportChild.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportChild.cpp View 3 chunks +28 lines, -4 lines 0 comments Download
M Source/core/html/imports/HTMLImportLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportLoader.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/html/imports/HTMLImportStateResolver.cpp View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hajime Morrita
PTAL? This is embarrassing. My test should've covered this but didn't because coverage was weak ...
6 years, 7 months ago (2014-05-15 21:42:36 UTC) #1
dglazkov
lgtm >_>
6 years, 7 months ago (2014-05-15 22:35:16 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 7 months ago (2014-05-16 08:24:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/289993004/1
6 years, 7 months ago (2014-05-16 08:24:25 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 08:39:14 UTC) #5
Message was sent while issue was closed.
Change committed as 174141

Powered by Google App Engine
This is Rietveld 408576698