Add validateOrigin() to the support library.

Add validateRelationship() to the support library.

This allows a client to request an origin to be validated as first-party
with respect to the calling app. Validation is asynchronous.

BUG=739165
Change-Id: I1a3543a773de9285217ec331759f8a94535b07a0
Review-Url: https://codereview.chromium.org/2978593002
Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/cff061038b852d647f7044d828a9df78aa135f38

[Benoit L, 2017-07-11 12:15:38]

Description was changed from

==========
Add validateOrigin() to the support library.

This allows a client to request an origin to be validated as first-party
with respect to the calling app. Validation is asynchronous.

Change-Id: I1a3543a773de9285217ec331759f8a94535b07a0
==========

to

==========
Add validateOrigin() to the support library.

This allows a client to request an origin to be validated as first-party
with respect to the calling app. Validation is asynchronous.

BUG=739165

Change-Id: I1a3543a773de9285217ec331759f8a94535b07a0
==========

[Benoit L, 2017-07-11 12:16:34]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[Yusuf, 2017-07-12 02:48:15]

lgtm for code

but I did have a realization about the API setup. Right now this API concerns
relationships about origin only. Later we may want to add a verification for
handle_all_urls, or in general we may want to expose a way to confirm various
other relationships as a browser service. So I wonder if this should more be in
the form

verifyRelationship(String relationship, Uri targetDomain, Bundle extras)

and then we add two constants for now for use_as_origin and handle_all_urls.
This way we can use this for new relationships by just adding new constants in
the future.

WDYT?

[Benoit L, 2017-07-12 16:42:58]

Description was changed from

==========
Add validateOrigin() to the support library.

This allows a client to request an origin to be validated as first-party
with respect to the calling app. Validation is asynchronous.

BUG=739165

Change-Id: I1a3543a773de9285217ec331759f8a94535b07a0
==========

to

==========
Add validateRelationship() to the support library.

This allows a client to request an origin to be validated as first-party
with respect to the calling app. Validation is asynchronous.

BUG=739165

Change-Id: I1a3543a773de9285217ec331759f8a94535b07a0
==========

[Benoit L, 2017-07-12 16:47:24]

Thanks for the suggestion!

Done, using an int instead of a String, as an opaque code is functionally the
same as an opaque string, and makes checking for a range of values easier.

PTAL, thanks!

Also, could you provide an example of future use?

[Yusuf, 2017-07-12 17:12:40]

lgtm. I agree that an int is better fitting here. 

For fullscreening for example, we will rely on RELATION_HANDLE_ALL_URLS.

We are debating whether Add to homescreen APKs can used a custom tab setup. If
they do, they won't
be needing a post message channel setup, so will need to verify handle_all_urls
through this API.

https://codereview.chromium.org/2978593002/diff/20001/customtabs/src/android/...
File customtabs/src/android/support/customtabs/CustomTabsService.java (right):

https://codereview.chromium.org/2978593002/diff/20001/customtabs/src/android/...
customtabs/src/android/support/customtabs/CustomTabsService.java:83: * origin to
be used as an origin.
Something to disambiguate the two "origin"s here and also clarify what we mean
by the second one?

"Requests the declared origin to be used as origin in web APIs/headers" I dont
think API/header are the right words though.

https://codereview.chromium.org/2978593002/diff/20001/customtabs/src/android/...
customtabs/src/android/support/customtabs/CustomTabsService.java:85: public
static final int RELATION_USE_AS_ORIGIN = 1;
can we also add RELATION_HANDLE_ALL_URLS = 2?

[Benoit L, 2017-07-13 13:05:56]

Done, thanks!

Can you take another look, though?
I have added the required things in the gradle file to make Android Studio happy
and the tests compile, but am not really familiar with this type of Android
development.

Also moved the int to @IntDef.

https://codereview.chromium.org/2978593002/diff/20001/customtabs/src/android/...
File customtabs/src/android/support/customtabs/CustomTabsService.java (right):

https://codereview.chromium.org/2978593002/diff/20001/customtabs/src/android/...
customtabs/src/android/support/customtabs/CustomTabsService.java:83: * origin to
be used as an origin.
On 2017/07/12 17:12:40, Yusuf wrote:
> Something to disambiguate the two "origin"s here and also clarify what we mean
> by the second one?
> 
> "Requests the declared origin to be used as origin in web APIs/headers" I dont
> think API/header are the right words though.

Done.

https://codereview.chromium.org/2978593002/diff/20001/customtabs/src/android/...
customtabs/src/android/support/customtabs/CustomTabsService.java:85: public
static final int RELATION_USE_AS_ORIGIN = 1;
On 2017/07/12 17:12:40, Yusuf wrote:
> can we also add RELATION_HANDLE_ALL_URLS = 2?

Done.

[Yusuf, 2017-07-13 17:24:10]

lgtm

But seeing you fix the gradle reminded me that you will probably be asked for a
unit test for this. I think it is fine to handle that on the framework review
though. It is better not to guess for other reviewers :)

https://codereview.chromium.org/2978593002/diff/40001/customtabs/src/android/...
File customtabs/src/android/support/customtabs/CustomTabsService.java (right):

https://codereview.chromium.org/2978593002/diff/40001/customtabs/src/android/...
customtabs/src/android/support/customtabs/CustomTabsService.java:88: * App ->
transitions, requests the app to use the declared origin to be used as origin in
Maybe

App->Web(?) transitions requests the browser to use the declared origin as
origin for the client app in the web APIs context. 

?

[Benoit L, 2017-07-18 11:36:59]

Thanks!

https://codereview.chromium.org/2978593002/diff/40001/customtabs/src/android/...
File customtabs/src/android/support/customtabs/CustomTabsService.java (right):

https://codereview.chromium.org/2978593002/diff/40001/customtabs/src/android/...
customtabs/src/android/support/customtabs/CustomTabsService.java:88: * App ->
transitions, requests the app to use the declared origin to be used as origin in
On 2017/07/13 17:24:09, Yusuf wrote:
> Maybe
> 
> App->Web(?) transitions requests the browser to use the declared origin as
> origin for the client app in the web APIs context. 
> 
> ?

Done.

[Yusuf, 2017-07-21 21:18:21]

Should we land this? I can actually use the new relationship definition in some
of the CLs I have locally.

Or will you wait for support lib approval to land?

Still lgtm :)

[Benoit L, 2017-07-27 09:43:04]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2017-07-27 09:43:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-27 09:44:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1501148584197230,
"parent_rev": "b1019f46ee9a0a873333958bb23e4260d112c8da", "commit_rev":
"cff061038b852d647f7044d828a9df78aa135f38"}

[commit-bot: I haz the power, 2017-07-27 09:44:32]

Description was changed from

==========
Add validateRelationship() to the support library.

This allows a client to request an origin to be validated as first-party
with respect to the calling app. Validation is asynchronous.

BUG=739165

Change-Id: I1a3543a773de9285217ec331759f8a94535b07a0
==========

to

==========
Add validateRelationship() to the support library.

This allows a client to request an origin to be validated as first-party
with respect to the calling app. Validation is asynchronous.

BUG=739165

Change-Id: I1a3543a773de9285217ec331759f8a94535b07a0
Review-Url: https://codereview.chromium.org/2978593002
Committed:
https://github.com/GoogleChrome/custom-tabs-client/commit/cff061038b852d647f7...
==========

[commit-bot: I haz the power, 2017-07-27 09:44:33]

Committed patchset #4 (id:60001) as
https://github.com/GoogleChrome/custom-tabs-client/commit/cff061038b852d647f7...