Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2978533002: Revert of [ios showcase] Integrated TextBadgeView with Showcase. (Closed)

Created:
3 years, 5 months ago by michaeldo
Modified:
3 years, 5 months ago
Reviewers:
gchatz, edchin, helenlyang
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews_chromium.org, ios-reviews+showcase_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios showcase] Integrated TextBadgeView with Showcase. (patchset #4 id:80001 of https://codereview.chromium.org/2967113003/ ) Reason for revert: This CL breaks ios_showcase_egtests suite (for tablet only). PTAL at the failure here: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/29530 and fix: - SCToolbarTestCase/testRotationSizeClassChange - SCToolbarTestCase/testVerifyToolbarButtonsLabelAndAction then re-land. Original issue's description: > [ios showcase] Integrated TextBadgeView with Showcase. > > This CL adds TextBadgeView to iOS Showcase. This involves adding a > text_badge_view folder to showcase, creating a glue view controller, > and modifying the Showcase configuration file and BUILD.gn files as > necessary. > > Since TextBadgeView is currently a stub implementation, Showcase > displays a blank white screen. > > BUG=740133 . > > Review-Url: https://codereview.chromium.org/2967113003 > Cr-Commit-Position: refs/heads/master@{#485302} > Committed: https://chromium.googlesource.com/chromium/src/+/ac8a93564a2560a5ec54673246c551e04e11ed02 TBR=edchin@chromium.org,gchatz@chromium.org,helenlyang@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=740133 .

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -100 lines) Patch
M ios/showcase/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/showcase/core/showcase_model.mm View 1 chunk +0 lines, -5 lines 0 comments Download
D ios/showcase/text_badge_view/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D ios/showcase/text_badge_view/sc_text_badge_view_controller.h View 1 chunk +0 lines, -13 lines 0 comments Download
D ios/showcase/text_badge_view/sc_text_badge_view_controller.mm View 1 chunk +0 lines, -24 lines 0 comments Download
D ios/showcase/text_badge_view/sc_text_badge_view_egtest.mm View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
michaeldo
Created Revert of [ios showcase] Integrated TextBadgeView with Showcase.
3 years, 5 months ago (2017-07-10 20:16:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978533002/1
3 years, 5 months ago (2017-07-10 20:16:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/912335bc3e0cf9a880286811d0f342c3a7f1c230
3 years, 5 months ago (2017-07-10 20:17:26 UTC) #6
gchatz
lgtm
3 years, 5 months ago (2017-07-10 20:45:46 UTC) #8
edchin
lgtm
3 years, 5 months ago (2017-07-13 16:19:44 UTC) #9
helenlyang
3 years, 5 months ago (2017-07-13 16:38:54 UTC) #10
On 2017/07/13 16:19:44, edchin wrote:
> lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698