DescriptionRevert of [ios showcase] Integrated TextBadgeView with Showcase. (patchset #4 id:80001 of https://codereview.chromium.org/2967113003/ )
Reason for revert:
This CL breaks ios_showcase_egtests suite (for tablet only). PTAL at the failure
here:
https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/29530
and fix:
- SCToolbarTestCase/testRotationSizeClassChange
-
SCToolbarTestCase/testVerifyToolbarButtonsLabelAndAction
then re-land.
Original issue's description:
> [ios showcase] Integrated TextBadgeView with Showcase.
>
> This CL adds TextBadgeView to iOS Showcase. This involves adding a
> text_badge_view folder to showcase, creating a glue view controller,
> and modifying the Showcase configuration file and BUILD.gn files as
> necessary.
>
> Since TextBadgeView is currently a stub implementation, Showcase
> displays a blank white screen.
>
> BUG=740133
.
>
> Review-Url: https://codereview.chromium.org/2967113003
> Cr-Commit-Position: refs/heads/master@{#485302}
> Committed: https://chromium.googlesource.com/chromium/src/+/ac8a93564a2560a5ec54673246c551e04e11ed02
TBR=edchin@chromium.org,gchatz@chromium.org,helenlyang@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=740133
.
Patch Set 1 #
Messages
Total messages: 10 (4 generated)
|