Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2978483002: Upload a new version of the BattOr firmware (Closed)

Created:
3 years, 5 months ago by charliea (OOO until 10-5)
Modified:
3 years, 5 months ago
Reviewers:
aschulman
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Upload a new version of the BattOr firmware This version of the firmware aborts reading back the SD card over the serial connection when bytes are received. We hope this fixes the problem where a command is retried during readback, but that command isn't heard. TBR=aschulman@chromium.org,rnephew@chromium.org BUG=chromium:737176 Review-Url: https://codereview.chromium.org/2978483002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9f7e1bcf98c37a17686b716fecf15233300cfa34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M common/battor/battor/battor_binary_dependencies.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
charliea (OOO until 10-5)
3 years, 5 months ago (2017-07-10 11:28:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978483002/1
3 years, 5 months ago (2017-07-10 11:28:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9f7e1bcf98c37a17686b716fecf15233300cfa34
3 years, 5 months ago (2017-07-10 11:53:31 UTC) #7
aschulman
3 years, 5 months ago (2017-07-10 13:23:40 UTC) #8
Message was sent while issue was closed.
On 2017/07/10 11:53:31, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

LGTM

Powered by Google App Engine
This is Rietveld 408576698