Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2978473002: Disable headless TargetDomain tests on Windows. (Closed)

Created:
3 years, 5 months ago by calamity
Modified:
3 years, 5 months ago
Reviewers:
altimin
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable headless TargetDomain tests on Windows. BUG=739458 TBR=altimin@chromium.org Review-Url: https://codereview.chromium.org/2978473002 Cr-Commit-Position: refs/heads/master@{#485514} Committed: https://chromium.googlesource.com/chromium/src/+/e7b32f631fe2e4e39d24e229e2ee1429e3cd01cc

Patch Set 1 #

Patch Set 2 : add disabling macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M headless/lib/headless_devtools_client_browsertest.cc View 1 5 chunks +19 lines, -0 lines 0 comments Download
M headless/test/headless_browser_test.h View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978473002/40001
3 years, 5 months ago (2017-07-11 03:31:21 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/e7b32f631fe2e4e39d24e229e2ee1429e3cd01cc
3 years, 5 months ago (2017-07-11 03:37:29 UTC) #18
calamity
3 years, 5 months ago (2017-07-11 03:45:02 UTC) #19
altimin
3 years, 5 months ago (2017-07-11 07:08:11 UTC) #20
Message was sent while issue was closed.
Interesting. LGTM to disable tests.

Powered by Google App Engine
This is Rietveld 408576698