Fix a crash in the fullscreen handler on Windows which occurs due to CHECK for success in creating …

Fix a crash in the fullscreen handler on Windows which occurs due to CHECK for success in creating the TaskBarList

It looks like assuming this COM object to be available in all cases is incorrect. We have other users in Chrome who
use this on a best effort basis. Additionally we need to call the HrInit() method on the ITaskBarList2 interface before
using it.

BUG=740376
TBR=msw

Review-Url: https://codereview.chromium.org/2978453002
Cr-Commit-Position: refs/heads/master@{#485161}
Committed: https://chromium.googlesource.com/chromium/src/+/3dc858ba5d7474567884f9b82234b281b14520f9

[ananta, 2017-07-09 14:30:59]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2017-07-09 14:38:38]

Description was changed from

==========
Fix a crash in the fullscreen handler on Windows which occurs due to CHECK for
success in creating the TaskBarList

It looks like assuming this COM object to be available in all cases is
incorrect. We have other users in Chrome who
use this on a best effort basis. Additionally we need to call the HrInit()
method on the ITaskBarList2 interface before
using it.

BUG=740376
==========

to

==========
Fix a crash in the fullscreen handler on Windows which occurs due to CHECK for
success in creating the TaskBarList

It looks like assuming this COM object to be available in all cases is
incorrect. We have other users in Chrome who
use this on a best effort basis. Additionally we need to call the HrInit()
method on the ITaskBarList2 interface before
using it.

BUG=740376
TBR=msw
==========

[ananta, 2017-07-09 14:38:38]

ananta@chromium.org changed reviewers:
+ msw@chromium.org

[ananta, 2017-07-09 14:39:04]

+msw. TBR'ing to fix the crash. Will address comments in a followup

[ananta, 2017-07-09 14:39:20]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-09 14:39:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-09 15:30:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-09 15:30:41]

Dry run: This issue passed the CQ dry run.

[ananta, 2017-07-09 19:28:11]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-07-09 19:28:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-09 19:31:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499628491103960, "parent_rev":
"b0ad7c5c03efbe8f725f85201c834389bf6a5b12", "commit_rev":
"3dc858ba5d7474567884f9b82234b281b14520f9"}

[commit-bot: I haz the power, 2017-07-09 19:31:33]

Description was changed from

==========
Fix a crash in the fullscreen handler on Windows which occurs due to CHECK for
success in creating the TaskBarList

It looks like assuming this COM object to be available in all cases is
incorrect. We have other users in Chrome who
use this on a best effort basis. Additionally we need to call the HrInit()
method on the ITaskBarList2 interface before
using it.

BUG=740376
TBR=msw
==========

to

==========
Fix a crash in the fullscreen handler on Windows which occurs due to CHECK for
success in creating the TaskBarList

It looks like assuming this COM object to be available in all cases is
incorrect. We have other users in Chrome who
use this on a best effort basis. Additionally we need to call the HrInit()
method on the ITaskBarList2 interface before
using it.

BUG=740376
TBR=msw

Review-Url: https://codereview.chromium.org/2978453002
Cr-Commit-Position: refs/heads/master@{#485161}
Committed:
https://chromium.googlesource.com/chromium/src/+/3dc858ba5d7474567884f9b82234...
==========

[commit-bot: I haz the power, 2017-07-09 19:31:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3dc858ba5d7474567884f9b82234...

[msw, 2017-07-10 18:53:31]

https://codereview.chromium.org/2978453002/diff/1/ui/views/win/fullscreen_han...
File ui/views/win/fullscreen_handler.cc (right):

https://codereview.chromium.org/2978453002/diff/1/ui/views/win/fullscreen_han...
ui/views/win/fullscreen_handler.cc:94: task_bar_list_ = nullptr;
Maybe we should have a flag to avoid retrying creation/init if it failed on the
first attempt? Otherwise, this block will retry each time it's hit.