Move the URLFetcher class used by the AppCacheUpdateJob class into its own file.

Move the URLFetcher class used by the AppCacheUpdateJob class into its own file.

This is in preparation for adding support in the URLFetcher class to use the network
URLLoader in the network service mode.

BUG=715632
TBR=jam

Review-Url: https://codereview.chromium.org/2978373002
Cr-Commit-Position: refs/heads/master@{#488555}
Committed: https://chromium.googlesource.com/chromium/src/+/609d97766b5ea2ff6fcf64d794fd986e0acaff71

[ananta, 2017-07-19 22:26:25]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[ananta, 2017-07-19 22:26:39]

ananta@chromium.org changed reviewers:
+ jam@chromium.org, michaeln@chromium.org

[commit-bot: I haz the power, 2017-07-19 22:26:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-19 22:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-19 22:41:01]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ananta, 2017-07-19 22:49:20]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-19 22:49:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-20 00:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-20 00:45:46]

Dry run: This issue passed the CQ dry run.

[michaeln, 2017-07-20 21:02:37]

lgtm

i think the only code change is adding buffer_size to the ctor, if there's any
other change please point it out

and hey, what about polygerrit?

[ananta, 2017-07-20 23:12:25]

On 2017/07/20 21:02:37, michaeln wrote:
> lgtm
> 
> i think the only code change is adding buffer_size to the ctor, if there's any
> other change please point it out
> 
> and hey, what about polygerrit?

The other change is making URLRequest a friend of the AppCacheUpdateJob.

[ananta, 2017-07-20 23:31:12]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-07-20 23:31:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-20 23:39:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-20 23:39:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ananta, 2017-07-20 23:58:32]

Description was changed from

==========
Move the URLFetcher class used by the AppCacheUpdateJob class into its own file.

This is in preparation for adding support in the URLFetcher class to use the
network
URLLoader in the network service mode.

BUG=715632
==========

to

==========
Move the URLFetcher class used by the AppCacheUpdateJob class into its own file.

This is in preparation for adding support in the URLFetcher class to use the
network
URLLoader in the network service mode.

BUG=715632
TBR=jam
==========

[ananta, 2017-07-20 23:58:37]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-07-20 23:58:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-21 02:12:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1500595117447780,
"parent_rev": "59f00a7d06b43ae4127637baaf7d8e8f5ee7847a", "commit_rev":
"609d97766b5ea2ff6fcf64d794fd986e0acaff71"}

[commit-bot: I haz the power, 2017-07-21 02:13:15]

Description was changed from

==========
Move the URLFetcher class used by the AppCacheUpdateJob class into its own file.

This is in preparation for adding support in the URLFetcher class to use the
network
URLLoader in the network service mode.

BUG=715632
TBR=jam
==========

to

==========
Move the URLFetcher class used by the AppCacheUpdateJob class into its own file.

This is in preparation for adding support in the URLFetcher class to use the
network
URLLoader in the network service mode.

BUG=715632
TBR=jam

Review-Url: https://codereview.chromium.org/2978373002
Cr-Commit-Position: refs/heads/master@{#488555}
Committed:
https://chromium.googlesource.com/chromium/src/+/609d97766b5ea2ff6fcf64d794fd...
==========

[commit-bot: I haz the power, 2017-07-21 02:13:16]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/609d97766b5ea2ff6fcf64d794fd...