Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2978363002: Revert of Add a row in the network tray to inform users to turn Bluetooth on to enable Tether. (Closed)

Created:
3 years, 5 months ago by sclittle
Modified:
3 years, 5 months ago
CC:
chromium-reviews, kalyank, sadrul, Ryan Hansberry, stevenjb, jhawkins, tdanderson, Jeremy Klein
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a row in the network tray to inform users to turn Bluetooth on to enable Tether. (patchset #13 id:240001 of https://codereview.chromium.org/2957043002/ ) Reason for revert: Broke compile on Linux ChromiumOS Builder (dbg), see https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29 Original issue's description: > Add a row in the network tray to inform users to turn Bluetooth on to enable Tether. > > Renamed TrayDetailsView::InfoLabel to TrayInfoLabel and moved it to its own file. It also now subclasses ActionableView instead of View, so it can be clickable. TrayInfoLabel::Delegate keeps track of whether or not the label is clickable, and handles clicks. > > BUG=672263, 735642 > > Review-Url: https://codereview.chromium.org/2957043002 > Cr-Commit-Position: refs/heads/master@{#487975} > Committed: https://chromium.googlesource.com/chromium/src/+/2257878a0dfb81bbbc37613752865983568580af TBR=khorimoto@chromium.org,jamescook@chromium.org,lesliewatkins@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672263, 735642 Review-Url: https://codereview.chromium.org/2978363002 Cr-Commit-Position: refs/heads/master@{#488008} Committed: https://chromium.googlesource.com/chromium/src/+/fc8ab64a4bd1d37a7eee1d50629750e79ba6553e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -321 lines) Patch
M ash/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/ash_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/bluetooth/tray_bluetooth.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/system/network/network_icon.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M ash/system/network/network_list.h View 5 chunks +4 lines, -10 lines 0 comments Download
M ash/system/network/network_list.cc View 3 chunks +4 lines, -15 lines 0 comments Download
M ash/system/tray/tray_details_view.h View 2 chunks +17 lines, -0 lines 0 comments Download
M ash/system/tray/tray_details_view.cc View 1 chunk +29 lines, -0 lines 0 comments Download
D ash/system/tray/tray_info_label.h View 1 chunk +0 lines, -57 lines 0 comments Download
D ash/system/tray/tray_info_label.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D ash/system/tray/tray_info_label_unittest.cc View 1 chunk +0 lines, -136 lines 0 comments Download
M ash/system/tray/tray_popup_item_style.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/system/tray/tray_popup_item_style.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sclittle
Created Revert of Add a row in the network tray to inform users to turn ...
3 years, 5 months ago (2017-07-19 22:08:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978363002/1
3 years, 5 months ago (2017-07-19 22:08:25 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-19 22:09:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc8ab64a4bd1d37a7eee1d506297...

Powered by Google App Engine
This is Rietveld 408576698