Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 297823003: DevTools: Remove async call stacks support for EventTarget.addEventListener. (Closed)

Created:
6 years, 7 months ago by aandrey
Modified:
6 years, 7 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

DevTools: Remove async call stacks support for EventTarget.addEventListener. BUG=372602, 370826, 272416 R=pfeldman, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -323 lines) Patch
M LayoutTests/inspector/sources/debugger/async-callstack.html View 4 chunks +1 line, -17 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-expected.txt View 1 chunk +14 lines, -49 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-middle-run.html View 3 chunks +2 lines, -75 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-middle-run-expected.txt View 1 chunk +3 lines, -40 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 3 chunks +1 line, -9 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 4 chunks +1 line, -99 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aandrey
6 years, 7 months ago (2014-05-22 16:19:54 UTC) #1
pfeldman
lgtm
6 years, 7 months ago (2014-05-22 17:27:08 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 7 months ago (2014-05-22 17:29:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/297823003/1
6 years, 7 months ago (2014-05-22 17:30:10 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 01:32:18 UTC) #5
Message was sent while issue was closed.
Change committed as 174627

Powered by Google App Engine
This is Rietveld 408576698