Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: Source/core/events/EventTarget.cpp

Issue 297823003: DevTools: Remove async call stacks support for EventTarget.addEventListener. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/events/EventTarget.cpp
diff --git a/Source/core/events/EventTarget.cpp b/Source/core/events/EventTarget.cpp
index 7110ca1cf8e93fb2b675d869f45559d60afbeb6c..9c78340747d39ca84f2f2f03102685967ab4bc0f 100644
--- a/Source/core/events/EventTarget.cpp
+++ b/Source/core/events/EventTarget.cpp
@@ -85,12 +85,7 @@ bool EventTarget::addEventListener(const AtomicString& eventType, PassRefPtr<Eve
// generated bindings), but breaks legacy content. http://crbug.com/249598
if (!listener)
return false;
- EventListener* eventListener = listener.get();
- if (ensureEventTargetData().eventListenerMap.add(eventType, listener, useCapture)) {
- InspectorInstrumentation::didAddEventListener(this, eventType, eventListener, useCapture);
- return true;
- }
- return false;
+ return ensureEventTargetData().eventListenerMap.add(eventType, listener, useCapture);
}
bool EventTarget::removeEventListener(const AtomicString& eventType, EventListener* listener, bool useCapture)
@@ -101,10 +96,8 @@ bool EventTarget::removeEventListener(const AtomicString& eventType, EventListen
size_t indexOfRemovedListener;
- RefPtr<EventListener> protect(listener);
if (!d->eventListenerMap.remove(eventType, listener, useCapture, indexOfRemovedListener))
return false;
- InspectorInstrumentation::didRemoveEventListener(this, eventType, listener, useCapture);
// Notify firing events planning to invoke the listener at 'index' that
// they have one less listener to invoke.
@@ -365,7 +358,6 @@ void EventTarget::removeAllEventListeners()
if (!d)
return;
d->eventListenerMap.clear();
- InspectorInstrumentation::didRemoveAllEventListeners(this);
// Notify firing events planning to invoke the listener at 'index' that
// they have one less listener to invoke.

Powered by Google App Engine
This is Rietveld 408576698