Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2978073002: Add closeBraceTokenFor and use it instead of BeginToken. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add closeBraceTokenFor and use it instead of BeginToken. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/3709ff515076eda7eaf5dc634f0bbda4ee51ed86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -407 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 14 chunks +26 lines, -20 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_listener.dart View 19 chunks +242 lines, -293 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 4 chunks +12 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 27 chunks +60 lines, -70 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/util.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_parser.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 2 chunks +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 5 months ago (2017-07-17 14:29:35 UTC) #2
danrubel
LGTM
3 years, 5 months ago (2017-07-17 14:57:47 UTC) #3
ahe
3 years, 5 months ago (2017-07-18 11:57:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3709ff515076eda7eaf5dc634f0bbda4ee51ed86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698