Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2978063002: Move parser helper classes to own files and clean them up. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move parser helper classes to own files and clean them up. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/3216bda0080532388cdf46ae52944c4a7e760523

Patch Set 1 #

Total comments: 1

Patch Set 2 : Don't use problems.dart in parser. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -240 lines) Patch
M pkg/analyzer/lib/src/fasta/analyzer_diet_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 4 chunks +6 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_listener.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analyzer/tool/summary/mini_ast.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/formal_parameter_builder.dart View 3 chunks +14 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 6 chunks +12 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser.dart View 1 chunk +16 lines, -7 lines 0 comments Download
A pkg/front_end/lib/src/fasta/parser/assert.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/class_member_parser.dart View 1 chunk +3 lines, -1 line 0 comments Download
A pkg/front_end/lib/src/fasta/parser/formal_parameter_kind.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 3 chunks +10 lines, -21 lines 0 comments Download
A pkg/front_end/lib/src/fasta/parser/member_kind.dart View 1 chunk +43 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/native_support.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 8 chunks +29 lines, -151 lines 0 comments Download
A pkg/front_end/lib/src/fasta/parser/parser_error.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A pkg/front_end/lib/src/fasta/parser/type_continuation.dart View 1 1 chunk +87 lines, -0 lines 0 comments Download
A pkg/front_end/lib/src/fasta/parser/util.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_parser.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/incremental/unlinked_unit.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
ahe
3 years, 5 months ago (2017-07-17 13:51:52 UTC) #2
danrubel
LGTM
3 years, 5 months ago (2017-07-17 14:09:24 UTC) #3
ahe
Made a minor tweak before submitting. https://codereview.chromium.org/2978063002/diff/1/pkg/front_end/lib/src/fasta/parser/type_continuation.dart File pkg/front_end/lib/src/fasta/parser/type_continuation.dart (right): https://codereview.chromium.org/2978063002/diff/1/pkg/front_end/lib/src/fasta/parser/type_continuation.dart#newcode7 pkg/front_end/lib/src/fasta/parser/type_continuation.dart:7: import '../problems.dart' show ...
3 years, 5 months ago (2017-07-18 10:13:38 UTC) #4
ahe
3 years, 5 months ago (2017-07-18 11:02:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3216bda0080532388cdf46ae52944c4a7e760523 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698