Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297803007: Move profile_chooser enums to a constant place for mac and win. (Closed)

Created:
6 years, 7 months ago by Mike Lerman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move profile_chooser enums to a constant place for mac and win. This will affect the cocoa and views versions of the profile_chooser. BUG=357693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272537

Patch Set 1 : comment #

Total comments: 2

Patch Set 2 : Cocoa nit #

Total comments: 12

Patch Set 3 : Nits and a private flag #

Patch Set 4 : Windows compile issues #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Unit tests need love too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -169 lines) Patch
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h View 1 2 5 chunks +7 lines, -30 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 2 3 4 5 22 chunks +51 lines, -45 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
A chrome/browser/ui/profile_chooser_constants.h View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.h View 1 2 3 4 6 chunks +8 lines, -32 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 3 4 22 chunks +55 lines, -52 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Mike Lerman
msw@chromium.org: Please review changes in c/b/ui/views and c/b/ui. shess@chromium.org: Please review changes in c/b/ui/cocoa. guohui@chromium.org: ...
6 years, 7 months ago (2014-05-21 18:20:39 UTC) #1
Scott Hess - ex-Googler
lgtm for cocoa, minor nit on the switch() structure. https://codereview.chromium.org/297803007/diff/40001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right): https://codereview.chromium.org/297803007/diff/40001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm#newcode918 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:918: ...
6 years, 7 months ago (2014-05-21 18:42:43 UTC) #2
Mike Lerman
https://codereview.chromium.org/297803007/diff/40001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right): https://codereview.chromium.org/297803007/diff/40001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm#newcode918 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:918: } On 2014/05/21 18:42:44, shess wrote: > While you're ...
6 years, 7 months ago (2014-05-21 18:58:22 UTC) #3
msw
https://codereview.chromium.org/297803007/diff/80001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h (left): https://codereview.chromium.org/297803007/diff/80001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h#oldcode44 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h:44: @private Keep this visibility modifier for the class members ...
6 years, 7 months ago (2014-05-21 19:42:47 UTC) #4
Mike Lerman
Thanks for the feedback, Mike https://codereview.chromium.org/297803007/diff/80001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h (left): https://codereview.chromium.org/297803007/diff/80001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h#oldcode44 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h:44: @private On 2014/05/21 19:42:47, ...
6 years, 7 months ago (2014-05-21 19:53:10 UTC) #5
msw
lgtm
6 years, 7 months ago (2014-05-21 20:00:09 UTC) #6
guohui
lgtm, thanks!
6 years, 7 months ago (2014-05-22 19:39:50 UTC) #7
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 7 months ago (2014-05-23 02:23:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/297803007/190001
6 years, 7 months ago (2014-05-23 02:25:08 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 06:06:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 07:58:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/31934)
6 years, 7 months ago (2014-05-23 07:58:01 UTC) #12
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 7 months ago (2014-05-23 15:16:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/297803007/190001
6 years, 7 months ago (2014-05-23 15:17:06 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 15:18:42 UTC) #15
Message was sent while issue was closed. 
Change committed as 272537

Powered by Google App Engine
This is Rietveld 408576698