chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm - Issue 297803007: Move profile_chooser enums to a constant place for mac and win.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

Issue 297803007: Move profile_chooser enums to a constant place for mac and win. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit tests need love too Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('k') | chrome/browser/ui/profile_chooser_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

index 8ebd298107fbfb63004f934c8b9ec08ae86a8dee..30c97291ae5332a16f3e2a7fd75d9e4231fefed7 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

@@ -68,7 +68,7 @@ class ProfileChooserControllerTest : public CocoaProfileTest {

controller_.reset([[ProfileChooserController alloc]

initWithBrowser:browser()

anchoredAt:point

- withMode:BUBBLE_VIEW_MODE_PROFILE_CHOOSER]);

+ withMode:profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER]);

[controller_ showWindow:nil];

}

@@ -378,7 +378,8 @@ TEST_F(ProfileChooserControllerTest, AccountManagementLayout) {

UpdateCredentials(kSecondaryEmail, kLoginToken);

StartProfileChooserController();

- [controller() initMenuContentsWithView:BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT];

+ [controller() initMenuContentsWithView:

+ profiles::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT];

NSArray* subviews = [[[controller() window] contentView] subviews];

EXPECT_EQ(1U, [subviews count]);

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('k') | chrome/browser/ui/profile_chooser_constants.h » ('j') | no next file with comments »