Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2978003002: config_service: add a popup for icons and make cards more compact. (Closed)

Created:
3 years, 5 months ago by ayanaadylova
Modified:
3 years, 5 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: add a popup for icons and make cards more compact. Add a popup while hovering over validation icons and force refresh button. Remove open button in the cards and make the whole card clickable. BUG=742480 Review-Url: https://codereview.chromium.org/2978003002 Committed: https://github.com/luci/luci-py/commit/4366b3c160568be03cc9c55e30690bf66a9eef9c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -53 lines) Patch
M appengine/config_service/ui/bower.json View 1 chunk +2 lines, -1 line 1 comment Download
M appengine/config_service/ui/src/config-ui/config-file-card.html View 2 chunks +11 lines, -20 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-set.html View 3 chunks +11 lines, -1 line 0 comments Download
M appengine/config_service/ui/src/config-ui/config-set-card.html View 5 chunks +44 lines, -28 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-ui.html View 2 chunks +1 line, -2 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/front-page.html View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
ayanaadylova
PTAL Link to the staging version: https://2965-dc53549-tainted-ayanaadylova-dot-luci-config.appspot.com/newui Screenshots Front-page: https://screenshot.googleplex.com/iB6YpqL5Zki Config-set page: https://screenshot.googleplex.com/en44SLkA54s
3 years, 5 months ago (2017-07-14 18:44:35 UTC) #2
Ryan Tseng
lgtm https://codereview.chromium.org/2978003002/diff/1/appengine/config_service/ui/bower.json File appengine/config_service/ui/bower.json (right): https://codereview.chromium.org/2978003002/diff/1/appengine/config_service/ui/bower.json#newcode21 appengine/config_service/ui/bower.json:21: "paper-tooltip": "PolymerElements/paper-tooltip#^2.0.0" Use exact version whenever possible
3 years, 5 months ago (2017-07-14 18:55:19 UTC) #4
nodir
this CL lgtm because it is an imporovement, but there i still a ton of ...
3 years, 5 months ago (2017-07-14 19:10:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978003002/1
3 years, 5 months ago (2017-07-17 16:04:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-py/commit/4366b3c160568be03cc9c55e30690bf66a9eef9c
3 years, 5 months ago (2017-07-17 16:07:07 UTC) #10
Sergey Berezin
3 years, 5 months ago (2017-07-18 00:22:28 UTC) #11
Message was sent while issue was closed.
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698