Remove deprecated_warningNotError.

Remove deprecated_warningNotError.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/17dc720681c14eac3c844947f1e38abaaad31d2d

[ahe, 2017-07-13 09:04:47]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-07-13 09:11:52]

lgtm

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:3017: .withArguments("Type
variable bounds not implemented yet."),
Any reason for not making this a template?

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:812: template: "Switch case may fall through to next
case."
to next case -> to the next case

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:815: template: "'#name' is final instance variable
that has already been initialized."
is final -> is a final

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:818: template: "'#name' was initialized here."
Kilroy was here!

[ahe, 2017-07-13 11:14:20]

Thank you, Johnni!

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:3017: .withArguments("Type
variable bounds not implemented yet."),
On 2017/07/13 09:11:51, Johnni Winther wrote:
> Any reason for not making this a template?

I've used the same template as `unimplemented`.

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:812: template: "Switch case may fall through to next
case."
On 2017/07/13 09:11:52, Johnni Winther wrote:
> to next case -> to the next case

Done.

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:815: template: "'#name' is final instance variable
that has already been initialized."
On 2017/07/13 09:11:51, Johnni Winther wrote:
> is final -> is a final

Done.

https://codereview.chromium.org/2977903002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:818: template: "'#name' was initialized here."
On 2017/07/13 09:11:52, Johnni Winther wrote:
> Kilroy was here!

Acknowledged.

[ahe, 2017-07-13 11:51:49]

Description was changed from

==========
Remove deprecated_warningNotError.
==========

to

==========
Remove deprecated_warningNotError.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/17dc720681c14eac3c844947f1e38abaaad31d2d
==========

[ahe, 2017-07-13 11:51:51]

Committed patchset #3 (id:40001) manually as
17dc720681c14eac3c844947f1e38abaaad31d2d.