Remove deprecated_warningNotError.

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.body_builder;
 
 import 'package:kernel/ast.dart'
     hide InvalidExpression, InvalidInitializer, InvalidStatement;
 
 import 'package:kernel/class_hierarchy.dart' show ClassHierarchy;
@@ skipping 2994 matching lines @@
       push(statement);
     }
   }
 
   @override
   void endTypeVariable(Token token, Token extendsOrSuper) {
     debugEvent("TypeVariable");
     DartType bound = pop();
     if (bound != null) {
       // TODO(ahe): To handle F-bounded types, this needs to be a TypeBuilder.
-      deprecated_warningNotError("Type variable bounds not implemented yet.",
+      warningNotError(
+          fasta.templateUnspecified
+              .withArguments("Type variable bounds not implemented yet."),

[Johnni Winther, 2017/07/13 09:11:51]

Any reason for not making this a template?

[ahe, 2017/07/13 11:14:19]

I've used the same template as `unimplemented`.

           offsetForToken(extendsOrSuper.next));
     }
     Identifier name = pop();
     // TODO(ahe): Do not discard metadata.
     pop(); // Metadata.
     push(new KernelTypeVariableBuilder(
         name.name, library, offsetForToken(name.token), null)
       ..finish(library, library.loader.coreLibrary["Object"]));
   }
 
@@ skipping 87 matching lines @@
   Expression deprecated_wrapInCompileTimeError(
       Expression expression, String message) {
     return new Let(
         new VariableDeclaration.forValue(expression)
           ..fileOffset = expression.fileOffset,
         deprecated_buildCompileTimeError(message, expression.fileOffset))
       ..fileOffset = expression.fileOffset;
   }
 
   Expression buildFallThroughError(int charOffset) {
-    deprecated_warningNotError(
-        "Switch case may fall through to next case.", charOffset);
+    warningNotError(fasta.messageSwitchCaseFallThrough, charOffset);
 
     Location location = messages.getLocationFromUri(uri, charOffset);
 
     return new Throw(buildStaticInvocation(
         library.loader.coreTypes.fallThroughErrorUrlAndLineConstructor,
         new Arguments(<Expression>[
           new StringLiteral(location?.file ?? uri.toString()),
           new IntLiteral(location?.line ?? 0)
         ]),
         charOffset: charOffset));
@@ skipping 40 matching lines @@
     if (builder is KernelFieldBuilder && builder.isInstanceMember) {
       initializedFields ??= <String, int>{};
       if (initializedFields.containsKey(name)) {
         return buildDuplicatedInitializer(
             name, offset, initializedFields[name]);
       }
       initializedFields[name] = offset;
       if (builder.isFinal && builder.hasInitializer) {
         // TODO(ahe): If CL 2843733002 is landed, this becomes a compile-time
         // error. Also, this is a compile-time error in strong mode.
-        deprecated_warningNotError(
-            "'$name' is final instance variable that has already been "
-            "initialized.",
+        warningNotError(
+            fasta.templateFinalInstanceVariableAlreadyInitialized
+                .withArguments(name),
             offset);
-        deprecated_warningNotError(
-            "'$name' was initialized here.", builder.charOffset);
+        warningNotError(
+            fasta.templateFinalInstanceVariableAlreadyInitializedCause
+                .withArguments(name),
+            builder.charOffset);
         Builder constructor =
             library.loader.getDuplicatedFieldInitializerError();
         return buildInvalidInitializer(
             new Throw(buildStaticInvocation(constructor.target,
                 new Arguments(<Expression>[new StringLiteral(name)]),
                 charOffset: offset)),
             offset);
       } else {
         return new FieldInitializer(builder.field, expression)
           ..fileOffset = offset;
@@ skipping 72 matching lines @@
 
   @override
   void deprecated_warning(String message, [int charOffset = -1]) {
     if (constantExpressionRequired) {
       deprecated_addCompileTimeError(charOffset, message);
     } else {
       super.deprecated_warning(message, charOffset);
     }
   }
 
-  void deprecated_warningNotError(String message, [int charOffset = -1]) {
-    super.deprecated_warning(message, charOffset);
-  }
-
   void warningNotError(Message message, int charOffset) {
     super.warning(message, charOffset);
   }
 
   @override
   DartType validatedTypeVariableUse(
       TypeParameterType type, int offset, bool nonInstanceAccessIsError) {
     if (!isInstanceContext && type.parameter.parent is Class) {
       String message = "Type variables can't be used in static members.";
       if (nonInstanceAccessIsError) {
@@ skipping 530 matching lines @@
       return AsyncMarker.Async;
     } else {
       assert(identical(starToken.stringValue, "*"));
       return AsyncMarker.AsyncStar;
     }
   } else {
     return unhandled(asyncToken.lexeme, "asyncMarkerFromTokens",
         asyncToken.charOffset, null);
   }
 }