Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: milo/buildsource/buildbucket/pubsub.go

Issue 2977863002: [milo] Refactor all html knowledge out of backends. (Closed)
Patch Set: now with case insensitivity Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/buildsource/buildbucket/html.go ('k') | milo/buildsource/buildbucket/struct.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/buildsource/buildbucket/pubsub.go
diff --git a/milo/buildsource/buildbucket/pubsub.go b/milo/buildsource/buildbucket/pubsub.go
index 1aea2c4af97c89fb0958be0293c1ff8c85c2dc81..d92a028c5c6ed6e0bcc0acf2d8da5d4794284893 100644
--- a/milo/buildsource/buildbucket/pubsub.go
+++ b/milo/buildsource/buildbucket/pubsub.go
@@ -52,8 +52,8 @@ var (
)
type parameters struct {
- builderName string `json:"builder_name"`
- properties string `json:"properties"`
+ BuilderName string `json:"builder_name"`
+ Properties string `json:"properties"`
}
func isLUCI(build *bucketApi.ApiCommonBuildMessage) bool {
@@ -184,7 +184,7 @@ func handlePubSubBuild(c context.Context, data *psMsg) error {
return err
}
logging.Debugf(c, "Received from %s: build %s/%s (%s)\n%s",
- host, build.Bucket, p.builderName, build.Status, build)
+ host, build.Bucket, p.BuilderName, build.Status, build)
if !isLUCI(build) {
logging.Infof(c, "This is not a luci build, ignoring")
buildCounter.Add(c, 1, build.Bucket, isLUCI(build), build.Status, "Rejected")
@@ -205,7 +205,7 @@ func handlePubSubBuild(c context.Context, data *psMsg) error {
buildCounter.Add(c, 1, build.Bucket, isLUCI(build), build.Status, action)
return saveBuildSummary(
- c, datastore.MakeKey(c, "buildEntry", buildEntry.key), p.builderName, buildEntry)
+ c, datastore.MakeKey(c, "buildEntry", buildEntry.key), p.BuilderName, buildEntry)
}
// This returns 500 (Internal Server Error) if it encounters a transient error,
« no previous file with comments | « milo/buildsource/buildbucket/html.go ('k') | milo/buildsource/buildbucket/struct.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698