[milo] Refactor all html knowledge out of backends.

milo/buildsource/buildbucket/pubsub.go

 // Copyright 2017 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbucket
 
 import (
         "encoding/json"
         "errors"
         "fmt"
@@ skipping 34 matching lines @@
         Build    bucketApi.ApiCommonBuildMessage
         Hostname string
 }
 
 var (
         errNoLogLocation = errors.New("log_location tag not found")
         errNoProject     = errors.New("project tag not found")
 )
 
 type parameters struct {
-        builderName string `json:"builder_name"`
-        properties  string `json:"properties"`
+        BuilderName string `json:"builder_name"`
+        Properties  string `json:"properties"`
 }
 
 func isLUCI(build *bucketApi.ApiCommonBuildMessage) bool {
         // All luci buckets are assumed to be prefixed with luci.
         return strings.HasPrefix(build.Bucket, "luci.")
 }
 
 // PubSubHandler is a webhook that stores the builds coming in from pubsub.
 func PubSubHandler(ctx *router.Context) {
         err := pubSubHandlerImpl(ctx.Context, ctx.Request)
@@ skipping 110 matching lines @@
         build := &data.Build
         p := parameters{}
         err := json.Unmarshal([]byte(build.ParametersJson), &p)
         if err != nil {
                 logging.WithError(err).Errorf(c, "could not unmarshal build parameters")
                 buildCounter.Add(c, 1, build.Bucket, isLUCI(build), build.Status, "Rejected")
                 // Permanent error, since this is probably a type of build we do not recognize.
                 return err
         }
         logging.Debugf(c, "Received from %s: build %s/%s (%s)\n%s",
-                host, build.Bucket, p.builderName, build.Status, build)
+                host, build.Bucket, p.BuilderName, build.Status, build)
         if !isLUCI(build) {
                 logging.Infof(c, "This is not a luci build, ignoring")
                 buildCounter.Add(c, 1, build.Bucket, isLUCI(build), build.Status, "Rejected")
                 return nil
         }
 
         buildEntry, err := processBuild(c, host, build)
         if err != nil {
                 logging.WithError(err).Errorf(c, "failed to update build")
                 buildCounter.Add(c, 1, build.Bucket, isLUCI(build), build.Status, "Rejected")
                 // Probably a datastore or network flake, make this into a transient error
                 return transient.Tag.Apply(err)
         }
         action := "Created"
         if buildEntry.created != buildEntry.modified {
                 action = "Modified"
         }
         buildCounter.Add(c, 1, build.Bucket, isLUCI(build), build.Status, action)
 
         return saveBuildSummary(
-                c, datastore.MakeKey(c, "buildEntry", buildEntry.key), p.builderName, buildEntry)
+                c, datastore.MakeKey(c, "buildEntry", buildEntry.key), p.BuilderName, buildEntry)
 }
 
 // This returns 500 (Internal Server Error) if it encounters a transient error,
 // and returns 200 (OK) if everything is OK, or if it encounters a permanent error.
 func pubSubHandlerImpl(c context.Context, r *http.Request) error {
         var data psMsg
 
         msg := common.PubSubSubscription{}
         defer r.Body.Close()
         dec := json.NewDecoder(r.Body)
         if err := dec.Decode(&msg); err != nil {
                 logging.WithError(err).Errorf(c, "could not decode message:\n%s", r.Body)
                 // This might be a transient error, e.g. when the json format changes
                 // and Milo isn't updated yet.
                 return transient.Tag.Apply(err)
         }
         bData, err := msg.GetData()
         if err != nil {
                 logging.WithError(err).Errorf(c, "could not parse pubsub message string")
                 return err
         }
         if err := json.Unmarshal(bData, &data); err != nil {
                 logging.WithError(err).Errorf(c, "could not parse pubsub message data")
                 return err
         }
 
         return handlePubSubBuild(c, &data)
 }