Fix dispatch_once deadlock

Fix dispatch_once deadlock
BUG=

Review-Url: https://codereview.chromium.org/2977833002
Cr-Commit-Position: refs/heads/master@{#486099}
Committed: https://chromium.googlesource.com/chromium/src/+/4153aff036de400191be6373e81b2bd6b9f195bc

[jzw1, 2017-07-12 19:55:05]

Description was changed from

==========
fix deadlock

BUG=
==========

to

==========
Fix dispatch_once deadlock
BUG=
==========

[jzw1, 2017-07-12 19:55:05]

jzw@chromium.org changed reviewers:
+ eugenebut@chromium.org, ichikawa@chromium.org, michaeldo@chromium.org

[jzw1, 2017-07-12 19:55:31]

On 2017/07/12 19:55:05, jzw1 wrote:
> mailto:jzw@chromium.org changed reviewers:
> + mailto:eugenebut@chromium.org, mailto:ichikawa@chromium.org,
mailto:michaeldo@chromium.org

PTAL

[michaeldo, 2017-07-12 20:04:32]

https://codereview.chromium.org/2977833002/diff/1/ios/web_view/internal/web_v...
File ios/web_view/internal/web_view_web_main_delegate.mm (right):

https://codereview.chromium.org/2977833002/diff/1/ios/web_view/internal/web_v...
ios/web_view/internal/web_view_web_main_delegate.mm:21: // We're using
CWVHTMLElement instead of CWVWebView and
Avoid we in comments. (Ref: go/avoidwe)

What about something like.
CWVWebView and CWVWebViewConfiguration must not be used here to avoid a deadlock
since their +initialize methods call this method.

[Eugene But (OOO till 7-30), 2017-07-12 20:05:37]

Looks strange, but it's not like I can offer anything better. lgtm

https://codereview.chromium.org/2977833002/diff/1/ios/web_view/internal/web_v...
File ios/web_view/internal/web_view_web_main_delegate.mm (right):

https://codereview.chromium.org/2977833002/diff/1/ios/web_view/internal/web_v...
ios/web_view/internal/web_view_web_main_delegate.mm:21: // We're using
CWVHTMLElement instead of CWVWebView and
nit: Please avoid "we" in the comments (go/avoidwe)

[jzw1, 2017-07-12 20:23:38]

https://codereview.chromium.org/2977833002/diff/1/ios/web_view/internal/web_v...
File ios/web_view/internal/web_view_web_main_delegate.mm (right):

https://codereview.chromium.org/2977833002/diff/1/ios/web_view/internal/web_v...
ios/web_view/internal/web_view_web_main_delegate.mm:21: // We're using
CWVHTMLElement instead of CWVWebView and
On 2017/07/12 20:05:37, Eugene But wrote:
> nit: Please avoid "we" in the comments (go/avoidwe)

Done.

[michaeldo, 2017-07-12 20:30:53]

lgtm

[jzw1, 2017-07-12 20:31:28]

The CQ bit was checked by jzw@chromium.org

[jzw1, 2017-07-12 20:31:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2977833002/#ps20001
(title: "avoid we")

[commit-bot: I haz the power, 2017-07-12 20:31:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 21:47:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499891488276050,
"parent_rev": "80b7c8a8aae2c2f9472962e59b11fb619d52d420", "commit_rev":
"4153aff036de400191be6373e81b2bd6b9f195bc"}

[commit-bot: I haz the power, 2017-07-12 21:47:35]

Description was changed from

==========
Fix dispatch_once deadlock
BUG=
==========

to

==========
Fix dispatch_once deadlock
BUG=

Review-Url: https://codereview.chromium.org/2977833002
Cr-Commit-Position: refs/heads/master@{#486099}
Committed:
https://chromium.googlesource.com/chromium/src/+/4153aff036de400191be6373e81b...
==========

[commit-bot: I haz the power, 2017-07-12 21:47:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4153aff036de400191be6373e81b...

[Hiroshi Ichikawa, 2017-07-13 04:46:19]

LGTM but maybe alternatively define a dummy empty class in
web_view_web_main_delegate.mm and use it?

[jzw1, 2017-07-13 06:20:17]

On 2017/07/13 04:46:19, Hiroshi Ichikawa wrote:
> LGTM but maybe alternatively define a dummy empty class in
> web_view_web_main_delegate.mm and use it?

That's actually a pretty good idea...I'll make that change.