Source/core/html/shadow/MediaControls.h - Issue 297783004: Implement heuristic for showing media controls during playback w/o a mouse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.h

Issue 297783004: Implement heuristic for showing media controls during playback w/o a mouse (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: IgnoreSelfHover -> IgnoreVideoHover; Tweak comment. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/MediaControls.h

diff --git a/Source/core/html/shadow/MediaControls.h b/Source/core/html/shadow/MediaControls.h

index 7a93cecaf5b23576bc0063e27bd69a2615e035fa..7879662b3cb244a33adf79f8f289c2d8f0c0e523 100644

--- a/Source/core/html/shadow/MediaControls.h

+++ b/Source/core/html/shadow/MediaControls.h

@@ -66,6 +66,8 @@ public:

void updateTextTrackDisplay();

+ void mediaElementFocused();

virtual void trace(Visitor*) OVERRIDE;

private:

@@ -78,7 +80,12 @@ private:

void updatePlayState();

- bool shouldHideMediaControls();

+ enum HideBehaviorFlags {

+ IgnoreVideoHover = 1 << 0,

+ IgnoreFocus = 1 << 1

+ };

+ bool shouldHideMediaControls(unsigned behaviorFlags = 0) const;

void hideMediaControlsTimerFired(Timer<MediaControls>*);

void startHideMediaControlsTimer();

void stopHideMediaControlsTimer();