Source/core/html/HTMLMediaElement.cpp - Issue 297783004: Implement heuristic for showing media controls during playback w/o a mouse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 297783004: Implement heuristic for showing media controls during playback w/o a mouse (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: IgnoreSelfHover -> IgnoreVideoHover; Tweak comment. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 9a70620667aa4f9032664dee09f16c8683e2ec11..595b8cbeb0b733cd76629a69e1cf5769936b019a 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -3645,6 +3645,15 @@ bool HTMLMediaElement::isInteractiveContent() const

return fastHasAttribute(controlsAttr);

}

+void HTMLMediaElement::defaultEventHandler(Event* event)

+ if (event->type() == EventTypeNames::focusin) {

+ if (hasMediaControls())

+ mediaControls()->mediaElementFocused();

+ }

+ HTMLElement::defaultEventHandler(event);

void HTMLMediaElement::trace(Visitor* visitor)

{

visitor->trace(m_error);