Implement heuristic for showing media controls during playback w/o a mouse

Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 173 matching lines @@
     makeOpaque();
 }
 
 void MediaControls::show()
 {
     makeOpaque();
     m_panel->setIsDisplayed(true);
     m_panel->show();
 }
 
+void MediaControls::mediaElementFocused()
+{
+    show();

[acolwell GONE FROM CHROMIUM, 2014/05/22 00:31:17]

Should we have a stopHideMediaControlsTimer() call here?

[fs, 2014/05/22 15:48:45]

Probably makes sense. Added.

+}
+
 void MediaControls::hide()
 {
     m_panel->setIsDisplayed(false);
     m_panel->hide();
 }
 
 void MediaControls::makeOpaque()
 {
     m_panel->makeOpaque();
 }
 
 void MediaControls::makeTransparent()
 {
     m_panel->makeTransparent();
 }
 
 bool MediaControls::shouldHideMediaControls()
 {
     return !m_panel->hovered();
 }
 
+bool MediaControls::shouldShowMediaControls() const
+{
+    if (m_isMouseOverControls)
+        return true;
+    // Check for 'focus' on the HTMLMediaElement and within the controls/shadow
+    // tree separately (to avoid going through all the potential ancestor hosts
+    // for the focused element.)
+    return mediaElement().focused() || contains(document().focusedElement());
+}
+
 void MediaControls::playbackStarted()
 {
     m_currentTimeDisplay->show();
     m_durationDisplay->hide();
 
     updatePlayState();
     m_timeline->setPosition(mediaElement().currentTime());
     updateCurrentTimeDisplay();
 
     startHideMediaControlsTimer();
 }
 
 void MediaControls::playbackProgressed()
 {
     m_timeline->setPosition(mediaElement().currentTime());
     updateCurrentTimeDisplay();
 
-    if (!m_isMouseOverControls && mediaElement().hasVideo())
+    if (mediaElement().hasVideo() && !shouldShowMediaControls())

[acolwell GONE FROM CHROMIUM, 2014/05/22 00:31:17]

!shouldShowMediaControls() conceptually seems like it should be equivalent to
shouldHideMediaControls(). Can we combine these into 1 function somehow so
different code paths don't end up disagreeing on whether the controls should be
visible or not? 

Also FYI https://codereview.chromium.org/296743007/ adds the hasVideo()
condition to shouldHideMediaControls() so that is one less check you'll have to
do here.

[fs, 2014/05/22 15:48:45]

I integrated should_Show_MediaControls in should_Hide_MediaControls (dropping
the hasVideo() check here per below).
 
I added that bit here, and will rebase and fix up as needed.

         makeTransparent();
 }
 
 void MediaControls::playbackStopped()
 {
     updatePlayState();
     m_timeline->setPosition(mediaElement().currentTime());
     updateCurrentTimeDisplay();
     makeOpaque();
 
@@ skipping 189 matching lines @@
 
 void MediaControls::updateTextTrackDisplay()
 {
     if (!m_textDisplayContainer)
         createTextTrackDisplay();
 
     m_textDisplayContainer->updateDisplay();
 }
 
 }