Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2977753002: DevTools: align keyboard shortcut with mouse action to toggle breakpoint enabled (Closed)

Created:
3 years, 5 months ago by luoe
Modified:
3 years, 5 months ago
Reviewers:
kozy, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: align keyboard shortcut with mouse action to toggle breakpoint enabled Cmd+B and gutter click both toggle breakpoint on a line. Gutter click + shift also disabled the current breakpoint. This CL aligns Cmd+Shift+B to disable the current breakpoint as well. BUG=741115 Review-Url: https://codereview.chromium.org/2977753002 Cr-Commit-Position: refs/heads/master@{#486152} Committed: https://chromium.googlesource.com/chromium/src/+/b66e999e669170eb39a790a6ede48cef36a13d82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 2 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ShortcutsScreen.js View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
luoe
Please take a look
3 years, 5 months ago (2017-07-11 22:07:37 UTC) #3
kozy
lgtm! But please wait for owner lgtm from Andrey :)
3 years, 5 months ago (2017-07-11 22:13:03 UTC) #4
lushnikov
lgtm
3 years, 5 months ago (2017-07-12 20:07:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977753002/1
3 years, 5 months ago (2017-07-12 20:10:46 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 23:37:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b66e999e669170eb39a790a6ede4...

Powered by Google App Engine
This is Rietveld 408576698