Remove deprecated api from LibraryBuilder.

Remove deprecated api from LibraryBuilder.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/83e4138cd419927dd30f58c9dbbf65e6faea2d43

[ahe, 2017-07-11 19:22:09]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-07-12 08:10:37]

lgtm

https://codereview.chromium.org/2977713002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right):

https://codereview.chromium.org/2977713002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:441:
templatePartOfUriMismatch.withArguments(
Should this message still refer to the issue?

https://codereview.chromium.org/2977713002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2977713002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:767: template: "Operator '#name' must have exactly
#number parameters."
This doesn't work with i8n. You need to split by number of required arguments
(even in english 'exactly 1 parameters' is wrong).

[ahe, 2017-07-12 20:07:58]

Thank you, Johnni!

https://codereview.chromium.org/2977713002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right):

https://codereview.chromium.org/2977713002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:441:
templatePartOfUriMismatch.withArguments(
On 2017/07/12 08:10:37, Johnni Winther wrote:
> Should this message still refer to the issue?

No, the issue was closed as the CL was reverted. In addition, warnings will
cause a non-zero exit code from the script we use to build platform.dill.

https://codereview.chromium.org/2977713002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2977713002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:767: template: "Operator '#name' must have exactly
#number parameters."
On 2017/07/12 08:10:37, Johnni Winther wrote:
> This doesn't work with i8n. You need to split by number of required arguments
> (even in english 'exactly 1 parameters' is wrong).

Good point, and in this case we only have a few numbers. I'll address this in a
follow-up CL and remove the #number kind again.

[ahe, 2017-07-12 20:31:19]

Description was changed from

==========
Remove deprecated api from LibraryBuilder.
==========

to

==========
Remove deprecated api from LibraryBuilder.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/83e4138cd419927dd30f58c9dbbf65e6faea2d43
==========

[ahe, 2017-07-12 20:31:21]

Committed patchset #1 (id:1) manually as
83e4138cd419927dd30f58c9dbbf65e6faea2d43 (presubmit successful).