Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2977633004: Remove all calls to domAutomationController.setAutomationId. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=tommi@chromium.org Review-Url: https://codereview.chromium.org/2977633004 Cr-Commit-Position: refs/heads/master@{#487944} Committed: https://chromium.googlesource.com/chromium/src/+/fe9cc5ebcb4a02561eb090c3c8f0ca4788e0aacb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M content/public/test/browser_test_utils.cc View 2 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Łukasz Anforowicz
tommi@, can you PTAL?
3 years, 5 months ago (2017-07-11 23:46:14 UTC) #3
tommi (sloooow) - chröme
lgtm
3 years, 5 months ago (2017-07-19 18:24:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977633004/1
3 years, 5 months ago (2017-07-19 18:24:41 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-19 20:19:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe9cc5ebcb4a02561eb090c3c8f0...

Powered by Google App Engine
This is Rietveld 408576698