Issue 297763004: Fix extension icons showing up with incorrect size on Chrome HiDPI Windows with scales of 150% and …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297763004: Fix extension icons showing up with incorrect size on Chrome HiDPI Windows with scales of 150% and … (Closed)

Created:
6 years, 7 months ago by ananta

Modified:
6 years, 7 months ago

Reviewers:
oshima, sky

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix extension icons showing up with incorrect size on Chrome HiDPI Windows with scales of 150% and above. The extension sources associated with icons were using the ui::GetImageScale function which returns the dpi scale on Windows HiDPI. Fix is to use the GetScaleForScaleFactor function instead. BUG=375461 R=oshima Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271856

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/extensions/api/extension_action/extension_action_api.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	chrome/browser/extensions/extension_icon_image.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/297763004/20001

6 years, 7 months ago (2014-05-20 23:42:28 UTC) #5

Message was sent while issue was closed.

Change committed as 271856

Expand Messages | Collapse Messages