Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4344)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 297763004: Fix extension icons showing up with incorrect size on Chrome HiDPI Windows with scales of 150% and … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_icon_image.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc
diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
index 70e6bbea3f4d5f1e79140b77b413dcfbc42b4714..feb395d9962101fa2848c01f8e13c35c4485b598 100644
--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc
+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
@@ -186,7 +186,7 @@ void SetDefaultsFromValue(const base::DictionaryValue* dict,
if (icon_value->GetString(kIconSizes[i].size_string, &str_value) &&
StringToSkBitmap(str_value, &bitmap)) {
CHECK(!bitmap.isNull());
- float scale = ui::GetImageScale(kIconSizes[i].scale);
+ float scale = ui::GetScaleForScaleFactor(kIconSizes[i].scale);
icon.AddRepresentation(gfx::ImageSkiaRep(bitmap, scale));
}
}
@@ -216,7 +216,7 @@ scoped_ptr<base::DictionaryValue> DefaultsToValue(ExtensionAction* action) {
if (!icon.isNull()) {
base::DictionaryValue* icon_value = new base::DictionaryValue();
for (size_t i = 0; i < arraysize(kIconSizes); i++) {
- float scale = ui::GetImageScale(kIconSizes[i].scale);
+ float scale = ui::GetScaleForScaleFactor(kIconSizes[i].scale);
if (icon.HasRepresentation(scale)) {
icon_value->SetString(
kIconSizes[i].size_string,
@@ -681,7 +681,7 @@ bool ExtensionActionSetIconFunction::RunExtensionAction() {
SkBitmap bitmap;
EXTENSION_FUNCTION_VALIDATE(IPC::ReadParam(&pickle, &iter, &bitmap));
CHECK(!bitmap.isNull());
- float scale = ui::GetImageScale(kIconSizes[i].scale);
+ float scale = ui::GetScaleForScaleFactor(kIconSizes[i].scale);
icon.AddRepresentation(gfx::ImageSkiaRep(bitmap, scale));
}
}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_icon_image.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698