Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 297753003: Ensure that YAML maps' map keys are order-independent. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Ensure that YAML maps' map keys are order-independent. R=jmesserly@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36399

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M pkg/yaml/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/yaml/lib/src/utils.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/yaml/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 4 months ago (2014-05-20 22:42:57 UTC) #1
Jennifer Messerly
https://codereview.chromium.org/297753003/diff/1/pkg/yaml/lib/src/utils.dart File pkg/yaml/lib/src/utils.dart (right): https://codereview.chromium.org/297753003/diff/1/pkg/yaml/lib/src/utils.dart#newcode23 pkg/yaml/lib/src/utils.dart:23: var equality = const SetEquality(); maybe use UnorderedIterableEquality and ...
5 years, 4 months ago (2014-05-20 22:51:24 UTC) #2
nweiz
https://codereview.chromium.org/297753003/diff/1/pkg/yaml/lib/src/utils.dart File pkg/yaml/lib/src/utils.dart (right): https://codereview.chromium.org/297753003/diff/1/pkg/yaml/lib/src/utils.dart#newcode23 pkg/yaml/lib/src/utils.dart:23: var equality = const SetEquality(); On 2014/05/20 22:51:25, John ...
5 years, 4 months ago (2014-05-20 22:58:54 UTC) #3
Jennifer Messerly
lgtm!
5 years, 4 months ago (2014-05-20 23:04:59 UTC) #4
nweiz
5 years, 4 months ago (2014-05-20 23:14:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r36399 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698