pkg/yaml/lib/src/utils.dart - Issue 297753003: Ensure that YAML maps' map keys are order-independent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/yaml/lib/src/utils.dart

Issue 297753003: Ensure that YAML maps' map keys are order-independent. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/yaml/lib/src/utils.dart

diff --git a/pkg/yaml/lib/src/utils.dart b/pkg/yaml/lib/src/utils.dart

index 64cad472704830ed7c5ac74e3ce58c1375a7b035..463af70133f992c7839a9ddfac29675ac25ba37b 100644

--- a/pkg/yaml/lib/src/utils.dart

+++ b/pkg/yaml/lib/src/utils.dart

@@ -20,7 +20,9 @@ int hashCodeFor(obj) {

parents.add(value);

try {

if (value is Map) {

- return _hashCodeFor(value.keys) ^ _hashCodeFor(value.values);

+ var equality = const UnorderedIterableEquality();

+ return equality.hash(value.keys.map(_hashCodeFor)) ^

+ equality.hash(value.values.map(_hashCodeFor));

} else if (value is Iterable) {

return const IterableEquality().hash(value.map(hashCodeFor));

}

« no previous file with comments | « pkg/yaml/CHANGELOG.md ('k') | pkg/yaml/pubspec.yaml » ('j') | no next file with comments »