Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2977423002: Fix bots, address duplicate error reporting later. (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bots, address duplicate error reporting later. My CL broke dartk/vm tests because I stopped reporting some errors accidentaly. I thought I was duplicating all error messages, but turns out that recoverable errors were only reported in the line fixed here. This reverts to the old behavior so we can address the reporting issues separately. Added details to: https://github.com/dart-lang/sdk/issues/30194 BUG= Committed: https://github.com/dart-lang/sdk/commit/2628d75c4b3b18b4485570dc2a88915cb145a74d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M pkg/front_end/lib/src/kernel_generator_impl.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-19 02:42:16 UTC) #2
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-19 02:42:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2628d75c4b3b18b4485570dc2a88915cb145a74d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698