Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: pkg/front_end/lib/src/kernel_generator_impl.dart

Issue 2977423002: Fix bots, address duplicate error reporting later. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/kernel_generator_impl.dart
diff --git a/pkg/front_end/lib/src/kernel_generator_impl.dart b/pkg/front_end/lib/src/kernel_generator_impl.dart
index 470dee0318d4dd7b16136fc552d4a4cebe40d0e5..8dd871af4bbda05d5e6ae60740b3f39ff1b49cd3 100644
--- a/pkg/front_end/lib/src/kernel_generator_impl.dart
+++ b/pkg/front_end/lib/src/kernel_generator_impl.dart
@@ -134,8 +134,10 @@ Future<CompilerResult> generateKernelInternal(
}
if (kernelTarget.errors.isNotEmpty) {
- // Note: we don't report errors here because they have been already
- // reported through the compiler context.
+ // TODO(sigmund): remove duplicate error reporting. Currently
+ // kernelTarget.errors contains recoverable and unrecoverable errors. We
+ // are reporting unrecoverable errors twice.
+ kernelTarget.errors.forEach((e) => options.report(e, Severity.error));
return null;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698