Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2977403002: Migrate test block 3 to Dart 2.0. (Closed)

Created:
3 years, 5 months ago by bkonyi
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom, siva, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate test block 3 to Dart 2.0. No major changes were needed for this block. BUG= R=jcollins@google.com, rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/3371365d8d1a859cbfadb513252697a6247b018c

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed Bob's nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2101 lines) Patch
D tests/corelib/bit_twiddling_bigint_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/corelib/bit_twiddling_test.dart View 1 chunk +0 lines, -173 lines 0 comments Download
D tests/corelib/bool_from_environment2_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/corelib/bool_from_environment_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/corelib/bool_hashcode_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/corelib/collection_from_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/corelib/collection_length_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D tests/corelib/collection_removes_test.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D tests/corelib/collection_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/corelib/collection_to_string_test.dart View 1 chunk +0 lines, -387 lines 0 comments Download
D tests/corelib/compare_to2_test.dart View 1 chunk +0 lines, -94 lines 0 comments Download
M tests/corelib/corelib.status View 5 chunks +0 lines, -12 lines 0 comments Download
A + tests/corelib_2/bit_twiddling_bigint_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/bit_twiddling_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/bool_from_environment2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/bool_from_environment_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/bool_hashcode_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/collection_from_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/collection_length_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/collection_removes_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/collection_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/collection_to_string_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/compare_to2_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 1 chunk +22 lines, -0 lines 0 comments Download
D tests/corelib_strong/bit_twiddling_bigint_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/corelib_strong/bit_twiddling_test.dart View 1 chunk +0 lines, -173 lines 0 comments Download
D tests/corelib_strong/bool_from_environment2_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/corelib_strong/bool_from_environment_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/corelib_strong/bool_hashcode_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/corelib_strong/collection_from_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/corelib_strong/collection_length_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D tests/corelib_strong/collection_removes_test.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D tests/corelib_strong/collection_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/corelib_strong/collection_to_string_test.dart View 1 chunk +0 lines, -387 lines 0 comments Download
D tests/corelib_strong/compare_to2_test.dart View 1 chunk +0 lines, -94 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
bkonyi
Here's my first block. I think I've covered everything here, but please let me know ...
3 years, 5 months ago (2017-07-18 20:29:20 UTC) #2
Bob Nystrom
Two nits then LGTM! https://codereview.chromium.org/2977403002/diff/1/tests/corelib_2/compare_to2_test.dart File tests/corelib_2/compare_to2_test.dart (right): https://codereview.chromium.org/2977403002/diff/1/tests/corelib_2/compare_to2_test.dart#newcode77 tests/corelib_2/compare_to2_test.dart:77: print("left: ${left} right: ${right}"); Remove ...
3 years, 5 months ago (2017-07-18 23:43:44 UTC) #3
bkonyi
https://codereview.chromium.org/2977403002/diff/1/tests/corelib_2/compare_to2_test.dart File tests/corelib_2/compare_to2_test.dart (right): https://codereview.chromium.org/2977403002/diff/1/tests/corelib_2/compare_to2_test.dart#newcode77 tests/corelib_2/compare_to2_test.dart:77: print("left: ${left} right: ${right}"); On 2017/07/18 23:43:44, Bob Nystrom ...
3 years, 5 months ago (2017-07-19 15:06:21 UTC) #4
jcollins
On 2017/07/19 15:06:21, bkonyi wrote: > https://codereview.chromium.org/2977403002/diff/1/tests/corelib_2/compare_to2_test.dart > File tests/corelib_2/compare_to2_test.dart (right): > > https://codereview.chromium.org/2977403002/diff/1/tests/corelib_2/compare_to2_test.dart#newcode77 > ...
3 years, 5 months ago (2017-07-19 15:23:33 UTC) #5
bkonyi
3 years, 5 months ago (2017-07-19 17:25:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3371365d8d1a859cbfadb513252697a6247b018c.

Powered by Google App Engine
This is Rietveld 408576698