Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2984443003: Migrate the language tests up to arithmetic_test. (Closed)

Created:
3 years, 5 months ago by Bob Nystrom
Modified:
3 years, 5 months ago
Reviewers:
bkonyi, Bill Hesse
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate the language tests up to arithmetic_test. This technically steals a few tests from the previous batch that spans corelib and language, but I wanted to start from the top of the language tests. Removed application_test and application_negative_test because they are useless and the latter has never actually worked correctly since the day it was transliterated from the long-defunct application file syntax. R=bkonyi@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/0947675d6d5c4b5d59e03f55283899202fbea482

Patch Set 1 #

Patch Set 2 : generic_methods_generic_function_result_test isn't working on DDC yet. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3114 lines) Patch
M pkg/front_end/test/fasta/parser/parser.status View 3 chunks +2 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/scanner/scanner.status View 2 chunks +0 lines, -2 lines 0 comments Download
D tests/language/abstract_factory_constructor_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/language/abstract_method_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/language/abstract_object_method_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/language/abstract_runtime_error_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/language/abstract_syntax_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language/accessor_conflict_export2_helper.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D tests/language/accessor_conflict_export2_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language/accessor_conflict_export_helper.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D tests/language/accessor_conflict_export_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language/accessor_conflict_getter.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language/accessor_conflict_import2_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language/accessor_conflict_import_prefixed2_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language/accessor_conflict_import_prefixed_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language/accessor_conflict_import_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language/accessor_conflict_setter.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/language/ackermann_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language/adjacent_const_string_literals_test.dart View 1 chunk +0 lines, -117 lines 0 comments Download
D tests/language/adjacent_string_literals_test.dart View 1 chunk +0 lines, -100 lines 0 comments Download
D tests/language/allocate_large_object_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/language/allocate_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D tests/language/allocation_sinking_inlining_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/language/application_negative_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language/application_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language/arg_param_trailing_comma_test.dart View 1 chunk +0 lines, -562 lines 0 comments Download
D tests/language/argument_definition_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/language/arithmetic_canonicalization_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D tests/language/arithmetic_smi_overflow_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language/arithmetic_test.dart View 1 chunk +0 lines, -558 lines 0 comments Download
D tests/language/empty_main.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language/failing_main.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 3 chunks +0 lines, -11 lines 0 comments Download
A + tests/language_2/abstract_factory_constructor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/language_2/abstract_getter2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/abstract_method_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/abstract_object_method_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/abstract_syntax_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language_2/accessor_conflict_export2_helper.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/accessor_conflict_export2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/accessor_conflict_export_helper.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/accessor_conflict_export_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/accessor_conflict_getter.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/accessor_conflict_import2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/accessor_conflict_import_prefixed2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/accessor_conflict_import_prefixed_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/accessor_conflict_import_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/accessor_conflict_setter.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/ackermann_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language_2/adjacent_const_string_literals_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/adjacent_string_literals_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/allocate_large_object_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/allocate_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/allocation_sinking_inlining_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/and_operation_on_non_integer_operand_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/arg_param_trailing_comma_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/arithmetic_canonicalization_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/arithmetic_smi_overflow_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/arithmetic_test.dart View 1 chunk +25 lines, -25 lines 0 comments Download
M tests/language_2/language_2.status View 1 1 chunk +23 lines, -4 lines 0 comments Download
D tests/language_strong/abstract_factory_constructor_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/language_strong/abstract_getter2_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/language_strong/abstract_method_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/language_strong/abstract_object_method_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/language_strong/abstract_runtime_error_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/language_strong/abstract_syntax_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language_strong/ackermann_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language_strong/adjacent_const_string_literals_test.dart View 1 chunk +0 lines, -117 lines 0 comments Download
D tests/language_strong/adjacent_string_literals_test.dart View 1 chunk +0 lines, -100 lines 0 comments Download
D tests/language_strong/allocate_large_object_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/language_strong/allocate_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D tests/language_strong/allocation_sinking_inlining_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/language_strong/and_operation_on_non_integer_operand_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/language_strong/application_negative_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language_strong/application_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language_strong/argument_definition_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/language_strong/arithmetic_canonicalization_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D tests/language_strong/arithmetic_smi_overflow_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language_strong/arithmetic_test.dart View 1 chunk +0 lines, -558 lines 0 comments Download
D tests/language_strong/empty_main.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language_strong/failing_main.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Bob Nystrom
3 years, 5 months ago (2017-07-17 22:59:26 UTC) #2
Bob Nystrom
Ben, mind taking a look at this since Janice is out?
3 years, 5 months ago (2017-07-18 22:05:09 UTC) #5
bkonyi
On 2017/07/18 22:05:09, Bob Nystrom wrote: > Ben, mind taking a look at this since ...
3 years, 5 months ago (2017-07-18 22:10:50 UTC) #6
bkonyi
LGTM! :)
3 years, 5 months ago (2017-07-18 22:28:50 UTC) #7
Bill Hesse
lgtm
3 years, 5 months ago (2017-07-19 13:27:09 UTC) #9
Bob Nystrom
3 years, 5 months ago (2017-07-20 03:30:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0947675d6d5c4b5d59e03f55283899202fbea482.

Powered by Google App Engine
This is Rietveld 408576698